Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Pull Request Template #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ocarissa
Copy link

@ocarissa ocarissa commented Dec 14, 2022

Add a Pull Request Template and some instruction sets on how to properly prepare a branch for merge into the main branch. We would like to propagate those docs into our numerous trustgraph public repositories so that we can promote keeping our main branches clean, clear, consistent, and decluttered for those working with us.

  • Add Pull Request Template
  • Add the PreppingForMerge_GitCLI.md written instruction into ../doc/onboarding directory (The PR template points to this instruction)

There was a previously opened PR #49 that is now deprecated, and this PR is the replacement for that PR. PR#49 will be closed-without-merge.

@ocarissa ocarissa added the documentation Improvements or additions to documentation label Dec 14, 2022
@ocarissa ocarissa self-assigned this Dec 14, 2022
@ocarissa ocarissa changed the title Adding Pull Request Template (same as core-nexus/vortex repo) Adding Pull Request Template Dec 14, 2022
@ocarissa
Copy link
Author

@harlantwood

I want to confirm before you review if we do also want the PreppingForMerge_GitCLI.md doc propagated to our public repositories too. Right now, I have added them, but if you decide you don't want those procedural guidelines in the public repos and only internal to our private repos, just let me know and I can adapt. :)

@ocarissa
Copy link
Author

@harlantwood

How do I extend the time-limit for the CI checks that get run here? It says "Cancelled after 45 min." I know this is possible to extend as zeek has had to do that in the past, just not sure where that gets changed for this repo and deployment pipeline.

@harlantwood
Copy link
Member

@harlantwood

I want to confirm before you review if we do also want the PreppingForMerge_GitCLI.md doc propagated to our public repositories too. Right now, I have added them, but if you decide you don't want those procedural guidelines in the public repos and only internal to our private repos, just let me know and I can adapt. :)

Let’s leave this out of the public repos, thanks 🙏

@harlantwood
Copy link
Member

@harlantwood

How do I extend the time-limit for the CI checks that get run here? It says "Cancelled after 45 min." I know this is possible to extend as zeek has had to do that in the past, just not sure where that gets changed for this repo and deployment pipeline.

Check the .github/workflows YAML files. Should be a timeout setting, at least in the TG holochain repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants