Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bundle for action.yml #249

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fixes bundle for action.yml #249

wants to merge 4 commits into from

Commits on Aug 10, 2024

  1. fix: do not supress output of trunk launcher

    The output contains critical information in case of launcher errors.
    
    The launcher currently completely suppresses all output (including all errors),
    unless `TRUNK_LAUNCHER_QUIET` env var is set to `false`.
    
    ```bash
    if [[ ${TRUNK_LAUNCHER_QUIET} != false ]]; then
      exec 3>&1 4>&2 &>/dev/null
    fi
    ```
    
    This prevents each and every one from debugging failed runs.
    Redirecting file descriptors like that also disables all `set -vx` output,
    resulting in a complete blackout and painful debugging.
    rindeal committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    c0db9eb View commit details
    Browse the repository at this point in the history
  2. fix: use BASH if expressions consistently

    Do not use POSIX test expressions.
    rindeal committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    9836e50 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2c2dda7 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2024

  1. fix: use --ci trunk option to supress "blank" lines

    The progress spinners cause a bunch of "blank"-looking lines
    in the log like this:
    ```
    2024-08-10T22:47:58.8716066Z �[2K�[0G
    2024-08-10T22:47:59.0718541Z �[2K�[0G
    2024-08-10T22:47:59.2719909Z �[2K�[0G
    2024-08-10T22:47:59.4720633Z �[2K�[0G
    2024-08-10T22:47:59.6722099Z �[2K�[0G
    2024-08-10T22:47:59.8722445Z �[2K�[0G
    2024-08-10T22:47:59.9751114Z �[2K�[0G
    2024-08-10T22:48:00.1794815Z �[2K�[0G�[0G
    2024-08-10T22:48:00.3794984Z �[2K�[0G
    2024-08-10T22:48:00.5797120Z �[2K�[0G
    2024-08-10T22:48:00.7798352Z �[2K�[0G
    2024-08-10T22:48:00.9799600Z �[2K�[0G
    2024-08-10T22:48:01.1800856Z �[2K�[0G
    2024-08-10T22:48:01.3802270Z �[2K�[0G
    2024-08-10T22:48:01.5803572Z �[2K�[0G
    2024-08-10T22:48:01.7804948Z �[2K�[0G
    2024-08-10T22:48:01.9805564Z �[2K�[0G
    2024-08-10T22:48:02.1806545Z �[2K�[0G
    2024-08-10T22:48:02.2442270Z �[2K�[0G
    2024-08-10T22:48:03.1623273Z �[2K�[0G�[1m�[32m
    2024-08-10T22:48:03.1625751Z ✔ �[0m�[1m10 linters were enabled �[0m�[90m(�[0m�[4m�[90m.trunk/trunk.yaml�[0m�[90m)
    ```
    
    `--ci` options reduces their refresh rate to 30s, effectively making it a non-issue.
    rindeal committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    9c5e39b View commit details
    Browse the repository at this point in the history