Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crawling more information #53

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

felixvonberlin
Copy link

This pull request allows the crawler to determine:

  • the block height
  • the minimum transaction fee required, and
  • the ledger version
    of the crawled nodes.

It also allows the crawler to determine

  • the common required transaction fee, and
  • the common block height
    in the network, if possible.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Merging #53 (81f7ee5) into main (7cd3159) will decrease coverage by 0.69%.
The diff coverage is 44.59%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   53.45%   52.76%   -0.69%     
==========================================
  Files           6        6              
  Lines         217      271      +54     
==========================================
+ Hits          116      143      +27     
- Misses        101      128      +27     
Files Changed Coverage Δ
src/crawl/net.rs 22.44% <0.00%> (-9.91%) ⬇️
src/io/report.rs 67.16% <67.56%> (+0.49%) ⬆️
src/crawl/core_types.rs 87.09% <100.00%> (+0.43%) ⬆️
src/crawl/crawler.rs 77.27% <100.00%> (+0.52%) ⬆️

Copy link
Member

@cndolo cndolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @felixvonberlin.
There are, however, a couple of things that need to be addressed before merging.

src/bin/mc-crawler.rs Outdated Show resolved Hide resolved
src/crawl/core_types.rs Outdated Show resolved Hide resolved
src/crawl/core_types.rs Outdated Show resolved Hide resolved
src/crawl/core_types.rs Outdated Show resolved Hide resolved
src/crawl/crawler.rs Outdated Show resolved Hide resolved
src/io/report.rs Outdated Show resolved Hide resolved
src/io/report.rs Outdated Show resolved Hide resolved
src/io/report.rs Outdated Show resolved Hide resolved
src/io/report.rs Show resolved Hide resolved
src/io/report.rs Show resolved Hide resolved
@felixvonberlin
Copy link
Author

@cndolo I have followed most of your advice; but in some cases I would like to discuss them first.

@cndolo
Copy link
Member

cndolo commented Oct 23, 2023

Thanks for your patience and addressing the comments @felixvonberlin . I still have a few minor issues and would be willing to merge once you have addressed those.

@felixvonberlin
Copy link
Author

it's fixed ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants