Update dependencies and clean up scss #710
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
changed the title
The dependency upgrade flagged some deprecated sass color function usage. When trying to fix them I discovered that none of the sass/scss setup is used in any layouts. Rather than reintroducing these old files I am getting rid of them. If we ever want to use scss again we should grab latest files from new jekyll version install and build from there instead of fixing this old cruft. Note that all layouts use assets/css/style.css and that does NOT import main from scss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #709 and #699
See more info about scss removal in the commit message.
Layouts do not seem to be affected at all, which makes sense since the css seems not to be used in any layout.
See preview - https://deploy-preview-710--trino.netlify.app/