-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Trino Snowflake connector story post. #653
base: master
Are you sure you want to change the base?
Add the Trino Snowflake connector story post. #653
Conversation
Cool article. Good for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great post. I have some comments, but feel free to disregard any of them, I think it's more important that it's clearly in your voice than polished to a T
c18b1b8
to
d41bcf4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ready - just needs a date update. We've also got a Trino Fest blog going up soon, maybe we should discuss on Slack to figure out the perfect timing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go now. Some minor nits to fix. Before we merge we just gotta change to the appropriate date.
264ff2f
to
c55e0c2
Compare
Done! |
c55e0c2
to
2c547a3
Compare
2c547a3
to
18a06f6
Compare
temp fix for the date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just looking at this again to see where things are at. I think we need to avoid the off-brand usage of a bunny to symbolize Commander Bun Bun unless we are happy with anybody doing that out there. Personally I think we should make sure CBB stays recognizable.
In terms of the content itself, I am still not sure how much on brand this should be vs how much it can be a personal view and perspective. In the later case it probably has to be made more explicit as a guest post or something like that.
All that in mind I am not sure how to best proceed. Not merge but advertise your original post on Trino channels? Modify and simplify and include explicit wording and link about the "full story from Brians perspective" and then advertise it?
I think @martint @dain @electrum and also @bitsondatadev should chime in on what is their suggested next step and preferences are here so we can proceed.
Adding the Snowlfake blog