Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise blacklist error on 403s #419

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alicederyn
Copy link

According to @rkh on issue #315, the Travis API will return a 403 if the "quite aggressive" auto-blocking bot blacklists your IP address. This PR raises an appropriate Error, not a NotLoggedIn exception, if Travis API returns a 403 when the Authorization header is not set. I'm not sure if this is totally correct, though: ideally, the API would return a unique status code, like 503 Service Unavailable with a huge Retry-After, so we could be absolutely sure. If we can do that, I'll update this PR accordingly.

If Travis API returns a 403 when the `Authorization` header is not set, raise an Error about blacklisting, not a NotLoggedIn exception.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant