Add Bluemix deploy provider #550
Conversation
Update json version dependency to avoid native code compile issues. Signed-off-by: Adam King <[email protected]>
.gitignore the coverage/ report directory to avoid accidentally committing code coverage reports. Signed-off-by: Adam King <[email protected]>
Add a deployment provider for Bluemix as a subclass of CloudFoundry deploy. The Bluemix provider uses the same options as Cloudfoundry, with the addition of a region choice, where setting the region determined the Bluemix api. Explicitly setting the API overrides the region setting. Signed-off-by: Adam King <[email protected]>
Add spec class to test Bluemix deploy provider Signed-off-by: Adam King <[email protected]>
| @@ -19,7 +19,7 @@ Gem::Specification.new do |s| | |||
| s.add_development_dependency 'rspec', '~> 3.0.0' | |||
| s.add_development_dependency 'rspec-its' | |||
| s.add_development_dependency 'rake' | |||
| s.add_development_dependency 'json', '1.8.1' | |||
| s.add_development_dependency 'json', '1.8.2' | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -0,0 +1,22 @@ | |||
| module DPL | |||
| class Provider | |||
| class BluemixCF < CloudFoundry | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Set dependncy back to JSON 1.8.1 ais required for Ruby 1.9.3 support Signed-off-by: Adam King <[email protected]>
|
Thanks for catching my mistake updating the json dependency. This is the first ruby I have done. I was having trouble with that package on Ubuntu 16, and I obviously chose the wrong solution. |
|
Cool. Could you work on documentation? It should go to https://github.com/travis-ci/docs-travis-ci-com. |
Update class name, provider reference, and test Signed-off-by: Travis CI <[email protected]>
Signed-off-by: Travis CI <[email protected]>
Rename BluemixCF class
Update json version dependency to avoid native code compile issues. Signed-off-by: Adam King <[email protected]>
.gitignore the coverage/ report directory to avoid accidentally committing code coverage reports. Signed-off-by: Adam King <[email protected]>
Add a deployment provider for Bluemix as a subclass of CloudFoundry deploy. The Bluemix provider uses the same options as Cloudfoundry, with the addition of a region choice, where setting the region determined the Bluemix api. Explicitly setting the API overrides the region setting. Signed-off-by: Adam King <[email protected]>
Add spec class to test Bluemix deploy provider Signed-off-by: Adam King <[email protected]>
Set dependncy back to JSON 1.8.1 ais required for Ruby 1.9.3 support Signed-off-by: Adam King <[email protected]>
Update class name, provider reference, and test Signed-off-by: Travis CI <[email protected]>
Signed-off-by: Travis CI <[email protected]>
|
I renamed the class as suggested. I was, and am, getting errors on most environments when travis builds the pull request, but I am not sure how its related to my change. I pulled the latest travis-ci/dpl master onto my fork, but it make a difference. I also looked at the https://github.com/travis-ci/docs-travis-ci-com documentation, but don't see an obvious area to update. What do you think about a pull request to add a CONTRIBUTING.md to dpl, or did you have something else in mind? |
|
Hi, @adamkingit, Sorry for the general lack of contribution guidance on docs. The deployment documentation should go to https://github.com/travis-ci/docs-travis-ci-com/tree/gh-pages/user/deployment. |
|
I updated docs and cli for bluemix and submitted pull requests for: |
|
Documentation pull request travis-ci/docs-travis-ci-com#925 now merged. |
|
Will release it tomorrow. |
Subclass the cloudfoundry provider to allow users to select bluemix regions by name, without needing to know the api host.
Add unit test coverage, as well as README.md documentation.
Example successful deployment at https://travis-ci.org/adamkingit/dpl/builds/184277695