Create render_jsonapi_test.rb #110
Conversation
Use of `render` for JSONAPI.
| include Roar::Rails::ControllerAdditions::Render | ||
|
|
||
| # NOTE: using :json_api will break | ||
| represents :json, :entity => SingerRepresenter, :collection => SingersRepresenter |
There was a problem hiding this comment.
Are you sure you want that? Both entities and collections must be rendered with the "same" representer using JSONAPI - this is a media format specification and not up to you. So, there should be no need to declare the :collection representer here, this must be sorted internally.
There was a problem hiding this comment.
Removing the :collection would throw this error: NameError: uninitialized constant RenderTest::SingersRepresenter. So I had to bake that in to make it work.
There was a problem hiding this comment.
Ok, for further contributions, keep in mind that you don't have to make tests work with hacks. For the author, it's even better if you submit breaking tests so they can see what's missing. It's actually my favourite PR style when people simply add a broken test.
Thanks, I'm pushing soon!
There was a problem hiding this comment.
Heh, that's the thing I didn't realize :collection was a hack... mostly because I'm not as into the Roar project as you are and you know what should work and when. Thanks for the tip and will definitely keep that in mind to provide broken tests! :)
Use of
renderfor JSONAPI.