I18n lazy lookup, closes #272 #279
Conversation
|
To be more clear - adding my |
|
Ok - that's because the |
|
@mbajur Can you add a test for that in a separate |
lib/cell/i18n.rb
Outdated
| def t(*args) | ||
| options = args.last.is_a?(Hash) ? args.pop.dup : {} | ||
| key = args.shift | ||
| cell_name = self.class.to_s.delete('Cell').underscore |
There was a problem hiding this comment.
This is deleting too much from the name (e.g. 'MenuCell'.delete('Cell') # => 'Mnu') ... I'd suggest e.g. gsub(/Cell\Z/, '') instead.
There was a problem hiding this comment.
yeah, that's exactly what i've done locally but forgot to send a PR for that. thanks
|
Yeah, i'd love to but i don't have much time for that right now. But i'll do that for sure in upcoming days. |
|
Great addition, too bad it stalled. 😢 |
Related to: #272
Ok, here is the raw module file. But still, after hundreds of attempts, i'm still not able to make it work as it should - using
t('.something')is not being overwriten and produces an error. It would be great if you could advice me on how that module should be actually used with cells. Included by default? Included separately for each cell?Sorry but i just think i'm missing something simple in here; no matter what i try, my overwrite is not visible from a single cell perspective and results in error