Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interp: fix fieldName method parsing embedded + generic fields #1572

Merged
merged 2 commits into from
Jul 1, 2023
Merged

interp: fix fieldName method parsing embedded + generic fields #1572

merged 2 commits into from
Jul 1, 2023

Conversation

zbysir
Copy link
Contributor

@zbysir zbysir commented Jun 27, 2023

Fix #1571

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ldez
Copy link
Contributor

ldez commented Jun 27, 2023

Hello,

can you add a test file?

@zbysir
Copy link
Contributor Author

zbysir commented Jun 27, 2023 •
edited by ldez
Loading

Hi, I added one test: 9b6d83c.

Is there a need for a separate test file?

@ldez
Copy link
Contributor

ldez commented Jun 27, 2023 •
edited
Loading

It's not the right place, you have to add a test file here.

@zbysir
Copy link
Contributor Author

zbysir commented Jun 27, 2023

Thanks for the tip, please review again

@ldez ldez requested a review from mvertes June 27, 2023 17:23
mvertes
mvertes approved these changes Jul 1, 2023
View reviewed changes
Copy link
Member

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvertes mvertes added this to the v0.15.x milestone Jul 1, 2023
@traefiker traefiker merged commit c10e468 into traefik:master Jul 1, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvertes mvertes mvertes approved these changes

Assignees
No one assigned
Labels
area/core bug Something isn't working
Projects
None yet
Milestone
v0.15.x
Development

Successfully merging this pull request may close these issues.

Cannot run embedded + generic code
5 participants
@zbysir @CLAassistant @ldez @mvertes @traefiker