Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Textarea] improve endAdornment positionning #302

Open
seedy opened this issue Feb 23, 2022 · 3 comments
Open

[Textarea] improve endAdornment positionning #302

seedy opened this issue Feb 23, 2022 · 3 comments
Labels
00-type/task enhancement New feature or request

Comments

@seedy
Copy link
Contributor

seedy commented Feb 23, 2022 •
edited
Loading

Description

When Textarea's content overflows horizontally, the endAdornment is not well positionned

image
@seedy seedy added enhancement New feature or request 00-type/task labels Feb 23, 2022
@seedy seedy self-assigned this Feb 23, 2022
@seedy seedy removed their assignment Mar 8, 2022
@paulocfjunior
Copy link
Contributor

I'm sorry, I'm not sure to get the use case for this change, would you mind providing an example where it results in bad responsiveness that would be fixed this way?
(I've played with the Textarea + EndAdornment and wasn't able to make it behave unexpectedly)

@seedy seedy self-assigned this Apr 7, 2022
@seedy
Copy link
Contributor Author

seedy commented Apr 7, 2022

@paulocfjunior I'm on it

@seedy seedy changed the title [Textarea] make endAdornment sticky positionned [Textarea] improve endAdornment positionning Apr 7, 2022
@seedy seedy removed their assignment Apr 7, 2022
@seedy seedy mentioned this issue Apr 7, 2022
Closed
6 tasks
@seedy
Copy link
Contributor Author

seedy commented Apr 7, 2022

@paulocfjunior I created a draft PR showing the problematic layout.

I think this is really an edge scenario for now.

In case we want to address this layout issue, I think we could give a try to the ScrollArea primitive.

I tried it very succinctly and didn't succeed to make it work as I wanted.

Until we have a need for this enhancement, I'd deprioritize it.

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
00-type/task enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add end adornment positionning issue story seedy/faency
2 participants
@seedy @paulocfjunior