getMeでDBを叩くように変更 #763
Open
getMeでDBを叩くように変更 #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pugma
reviewed
Jun 7, 2024
| @@ -82,11 +82,27 @@ func (h Handlers) GetMe(c echo.Context) error { | |||
| h.Logger.Error("failed to get session", zap.Error(err)) | |||
| return echo.NewHTTPError(http.StatusInternalServerError, err) | |||
| } | |||
| user, ok := sess.Values[sessionUserKey].(User) | |||
| user_in_session, ok := sess.Values[sessionUserKey].(User) | |||
There was a problem hiding this comment.
めちゃ横槍で申し訳ないけど、プライベートな変数はローワーキャメルケースが標準な気がします
Suggested change
| user_in_session, ok := sess.Values[sessionUserKey].(User) | |
| userInSession, ok := sess.Values[sessionUserKey].(User) |
H1rono
requested changes
Jun 8, 2024
router/user.go
Outdated
Comment on lines
91
to
100
| users, err := h.Repository.GetUsers(c.Request().Context()) | ||
| if err != nil { | ||
| h.Logger.Error("failed to get users from repository", zap.Error(err)) | ||
| return echo.NewHTTPError(http.StatusInternalServerError, err) | ||
| } | ||
| for _, user_i := range users { | ||
| if user_i.ID == user_in_session.ID { | ||
| return c.JSON(http.StatusOK, user_i) | ||
| } | ||
| } |
There was a problem hiding this comment.
おかしい
UserRepository.GetUserByIDがあるのでそちらを使うべきです
Line 23 in 444568f
userが存在しない場合は何かしらのerrが返ってくるはずなので、それに応じて後に処理を続けてください
|
とりあえずこれ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#725