Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/admin/meetings/:meetingID の event information の実装 #204

Merged
merged 4 commits into from
Jul 18, 2023

Conversation

Rozelin-dc
Copy link
Member

@Rozelin-dc Rozelin-dc commented Jul 18, 2023

close #114
APIは親のページコンポーネントで呼び出すと想定して、編集・削除はemitで通知する形にしています

動作確認用

<script setup lang="ts">
import { reactive } from 'vue'
import { Meeting } from '@/lib/apis'
import EventInformation from '@/components/EventDetail/EventInformation.vue'

const m = reactive<Meeting>({
  id: 'c714a848-2886-4c10-a313-de9bc61cb2bb',
  title: '第n回メンバー集会',
  description:
    '長めの説明長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い長い',
  thumbnail:
    'https://i.ytimg.com/vi/lMEt3RdqB9Y/hq720.jpg?sqp=-oaymwEcCNAFEJQDSFXyq4qpAw4IARUAAIhCGAFwAcABBg==&rs=AOn4CLCzfCHH_ecPXfsWt8DAud71QpvkbQ',
  startedAt: '2018-07-13 17:54:01',
  endedAt: '',
  videoId: 'D6DVTLvOupE'
})
</script>

<template>
  <event-information
    :meeting="m"
    @update-description="$event => (m.description = $event)"
    @delete="() => console.log('delete')"
  />
</template>

@Rozelin-dc Rozelin-dc self-assigned this Jul 18, 2023
@Rozelin-dc Rozelin-dc requested a review from mehm8128 July 18, 2023 03:10
Copy link
Member

@mehm8128 mehm8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうです!
tokensのとき見出しも入れちゃったんですけど、見出しは親側でつけるようにする感じですかね:thinking:(↓これ)
image

@Rozelin-dc
Copy link
Member Author

親でいいかなと思ってます

@mehm8128
Copy link
Member

OKです、じゃあマージお願いしますー(tokensもあとで親で見出しつけるように直しときます)

@Rozelin-dc Rozelin-dc merged commit 6a96e2b into main Jul 18, 2023
5 checks passed
@Rozelin-dc Rozelin-dc deleted the feat/event_information branch July 18, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

event informationコンポーネントの作成
2 participants