Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peripheral-firmware: extract on boot by default #94

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Enzime
Copy link
Contributor

@Enzime Enzime commented Aug 22, 2023

This improves the situation for flake users, as previously they had to either add the non-redistributable firmware to their repositories or go without the firmware.

This change also brings the ISO into line with the regular NixOS modules as storing the peripheral firmware in the Nix Store is no longer a requirement.

@tpwrules
Copy link
Owner

tpwrules commented Aug 25, 2023

I do not think I agree with this change at this time.

  1. It exposes us to race conditions between drivers which need the firmware and the extraction of it.
  2. It means firmware is less controlled by the generational mechanism which could create incompatibilities in updates. Admittedly this is not exceptionally well defined by default but these changes would make rolling back a firmware ESP file update through the bootloader menu impossible.
  3. It brings Python and a bunch of libraries into the system closure.

Let's revisit this once the mechanism by which firmware updates occur is defined. I will give some more thought to the flakes case in a bit. It might even be possible to grab the firmware files ourselves using bits of the installer and sidestep this issue.

@tpwrules tpwrules mentioned this pull request Dec 24, 2023
@Enzime Enzime force-pushed the refactor/peripheral-firmware branch from 488feab to 88ce930 Compare June 26, 2024 03:03
@Enzime Enzime force-pushed the refactor/peripheral-firmware branch from 88ce930 to 7cf4746 Compare August 30, 2024 23:26
This improves the situation for flake users, as previously they had to
either add the non-redistributable firmware to their repositories or go
without the firmware.

This change also brings the ISO into line with the regular NixOS modules
as storing the peripheral firmware in the Nix Store is no longer a
requirement.
@Enzime Enzime force-pushed the refactor/peripheral-firmware branch from 7cf4746 to b75fc50 Compare September 6, 2024 06:15
@MatthewCroughan
Copy link

Is it possible we could have this available as a module option, off by default? I would like to use it, but would have to maintain my own fork of nixos-apple-silicon, or use @Enzime's branch if it's not maintained here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants