#445 mandatory user id extractor #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #447 +/- ##
===========================================
- Coverage 41.35% 41.30% -0.06%
===========================================
Files 80 81 +1
Lines 4996 4983 -13
===========================================
- Hits 2066 2058 -8
+ Misses 2930 2925 -5 ☔ View full report in Codecov by Sentry. |
mario-nt
force-pushed
the
#445-mandatory-user-id-extractor
branch
from
da04c2a
to
43af0b0
Compare
|
Hi @mario-nt there is a failing check: https://github.com/torrust/torrust-index/actions/runs/7718691642/job/21040511408?pr=447#step:7:11 |
josecelano
requested changes
Jan 31, 2024
There was a problem hiding this comment.
Hi @mario-nt It looks good to me, but the testing workflow is failing. And make sure it works with the Index GUI.
mario-nt
force-pushed
the
#445-mandatory-user-id-extractor
branch
from
3bca16a
to
689291d
Compare
mario-nt
force-pushed
the
#445-mandatory-user-id-extractor
branch
from
689291d
to
84e9d56
Compare
|
The |
mario-nt
force-pushed
the
#445-mandatory-user-id-extractor
branch
from
84e9d56
to
59b1cce
Compare
|
@josecelano Rebased |
|
ACK 59b1cce |
josecelano
approved these changes
Feb 7, 2024
josecelano
added a commit
that referenced
this pull request
Feb 20, 2024
21f533f refactor: [#445] fix formatting warning (Mario) 61388de fix: [#445] refactor handlers with new user id extractor (Mario) Pull request description: Fixes #447, some changes to the code were lost in a merge, this PR restores those changes. ACKs for top commit: josecelano: ACK 21f533f Tree-SHA512: ae2cd790d6f9d1d92d91ef3e052d21314b773b32a77ad1f8373add804661bf83b7dc55a9535dc74bd73bc33b41b9d808154bc9dddcfc9f88c00ff679f4b86467
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #445