Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for official Django & Python versions #51

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

irtazaakram
Copy link
Contributor

Hi,

This PR

  • adds support for Django 4.0, 4.1 & 4.2
  • adds support for Python 3.10 & 3.11
  • update GitHub actions

Can we have a new release after this PR is merged

Thanks,

Copy link
Member

@gasman gasman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @irtazaakram! Just a bit of minor feedback on the changes here.

Just wondering - since there are no actual code changes here, presumably the current release works fine with newer Django / Python versions. Is there actually a need for a new release?

.github/workflows/test.yml Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@irtazaakram
Copy link
Contributor Author

Hi @gasman,

Thank you for the review. I've removed all Python & Django unsupported versions.

Thanks,

Copy link
Member

@gasman gasman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates - all looking good!

@gasman gasman merged commit 2e0b15b into torchbox:main Sep 19, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants