Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add debug for message_id and cert_id #485

Closed
wants to merge 11 commits into from
Closed

Conversation

gruberb
Copy link
Contributor

@gruberb gruberb commented Mar 22, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Additions and Changes

Please explain in detail, if applicable, which changes you performed in the PR and link them to issues. (If not applicable you can remove this whole section)

Bug fix (non-breaking change which fixes an issue)

New feature (non-breaking change which adds functionality)

Breaking changes

Please explain in detail which changes are breaking changes in the PR. (If not applicable you can remove this whole section)

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 75.34247% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 69.25%. Comparing base (b2a1af0) to head (fee7209).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/topos-tce/src/app_context/protocol.rs 60.86% 9 Missing ⚠️
crates/topos-tce/src/app_context/network.rs 57.14% 6 Missing ⚠️
crates/topos-p2p/src/behaviour/gossip.rs 88.88% 2 Missing ⚠️
crates/topos-tce/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
- Coverage   72.09%   69.25%   -2.85%     
==========================================
  Files         227      219       -8     
  Lines       12831    12871      +40     
==========================================
- Hits         9251     8914     -337     
- Misses       3580     3957     +377     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gruberb gruberb closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants