Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify the double echo state change #254

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Conversation

hadjiszs
Copy link
Member

Description

Simple refactor to ease the split to dedicated tasks

Fixes TP-597

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@hadjiszs hadjiszs requested a review from a team as a code owner June 27, 2023 01:00
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #254 (f8671fb) into main (21b3d3f) will decrease coverage by 0.06%.
The diff coverage is 93.47%.

❗ Current head f8671fb differs from pull request most recent head 8efdfdc. Consider uploading reports for the commit 8efdfdc to get more accurate results

@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
- Coverage   53.89%   53.83%   -0.06%     
==========================================
  Files         177      177              
  Lines        9264     9248      -16     
==========================================
- Hits         4993     4979      -14     
+ Misses       4271     4269       -2     
Impacted Files Coverage Δ
crates/topos-tce-broadcast/src/lib.rs 53.70% <ø> (-0.29%) ⬇️
crates/topos-tce-broadcast/src/double_echo/mod.rs 85.50% <93.18%> (-0.21%) ⬇️
crates/topos-tce-broadcast/src/sampler/mod.rs 41.17% <100.00%> (+2.28%) ⬆️
crates/topos-tce-broadcast/src/tests/mod.rs 98.23% <100.00%> (-0.02%) ⬇️

@Freyskeyd Freyskeyd merged commit 4e911bb into main Jul 3, 2023
17 of 18 checks passed
@Freyskeyd Freyskeyd deleted the feat/TP-597 branch July 3, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants