Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cleanup app_context #252

Merged
merged 2 commits into from
Jul 11, 2023
Merged

feat: cleanup app_context #252

merged 2 commits into from
Jul 11, 2023

Conversation

Freyskeyd
Copy link
Member

Description

In order to gain more visibility and ease the refactor process on the tce I splitted the app-context into different file

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested a review from a team as a code owner June 26, 2023 09:14
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #252 (9c73f88) into main (9d1089f) will increase coverage by 0.48%.
The diff coverage is 80.06%.

❗ Current head 9c73f88 differs from pull request most recent head 86f208b. Consider uploading reports for the commit 86f208b to get more accurate results

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
+ Coverage   53.14%   53.62%   +0.48%     
==========================================
  Files         198      183      -15     
  Lines        9990     9264     -726     
==========================================
- Hits         5309     4968     -341     
+ Misses       4681     4296     -385     
Impacted Files Coverage Δ
crates/topos-tce/src/app_context.rs 88.46% <ø> (+15.56%) ⬆️
crates/topos-tce/src/config.rs 0.00% <0.00%> (ø)
crates/topos-tce/src/lib.rs 0.79% <ø> (-8.95%) ⬇️
crates/topos-tce/src/app_context/network.rs 76.47% <76.47%> (ø)
crates/topos-tce/src/app_context/protocol.rs 77.55% <77.55%> (ø)
crates/topos-tce/src/app_context/api.rs 83.33% <83.33%> (ø)
crates/topos-tce/src/app_context/message.rs 100.00% <100.00%> (ø)
crates/topos-tce/src/metrics.rs 100.00% <100.00%> (ø)

... and 86 files with indirect coverage changes

Copy link
Contributor

@gruberb gruberb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Freyskeyd Freyskeyd force-pushed the feature/cleanup-app-context branch from 9c73f88 to 72d8673 Compare July 4, 2023 09:16
Signed-off-by: Simon Paitrault <[email protected]>
@Freyskeyd Freyskeyd force-pushed the feature/cleanup-app-context branch from 72d8673 to b088658 Compare July 11, 2023 15:21
@Freyskeyd Freyskeyd merged commit 33788fd into main Jul 11, 2023
18 checks passed
@Freyskeyd Freyskeyd deleted the feature/cleanup-app-context branch July 11, 2023 15:33
gruberb pushed a commit that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants