-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change impl to process transaction receipts #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDawg287
force-pushed
the
feature/TP-654
branch
from
August 4, 2023 21:46
74c14ad
to
0c2e980
Compare
JDawg287
force-pushed
the
feature/TP-654
branch
from
August 4, 2023 21:54
0c2e980
to
db03527
Compare
JDawg287
force-pushed
the
feature/TP-654
branch
from
August 17, 2023 20:08
a5e79b7
to
a699d84
Compare
sebastiendan
force-pushed
the
feature/TP-654
branch
from
August 18, 2023 10:50
4513a28
to
2d85f2c
Compare
Signed-off-by: Jawad Tariq <[email protected]>
Signed-off-by: Jawad Tariq <[email protected]>
Signed-off-by: Jawad Tariq <[email protected]>
Signed-off-by: Jawad Tariq <[email protected]>
Signed-off-by: Jawad Tariq <[email protected]>
atanmarko
reviewed
Aug 22, 2023
atanmarko
approved these changes
Aug 22, 2023
Signed-off-by: Jawad Tariq <[email protected]>
Signed-off-by: Jawad Tariq <[email protected]>
Signed-off-by: Jawad Tariq <[email protected]>
Signed-off-by: Jawad Tariq <[email protected]>
JDawg287
force-pushed
the
feature/TP-654
branch
from
August 22, 2023 19:35
2d85f2c
to
8dadb25
Compare
Signed-off-by: Jawad Tariq <[email protected]>
hadjiszs
reviewed
Aug 25, 2023
sebastiendan
added a commit
that referenced
this pull request
Aug 28, 2023
Signed-off-by: Jawad Tariq <[email protected]> Co-authored-by: Sébastien Dan <[email protected]>
sebastiendan
added a commit
that referenced
this pull request
Aug 28, 2023
Signed-off-by: Jawad Tariq <[email protected]> Co-authored-by: Sébastien Dan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes how cross-subnet messages are sent from one subnet to another. Before this PR, we used transaction data and the
transactionsRoot
as the basis for the cross-subnet messaging protocol. It actually makes more sense to use the transaction receipt data and thereceiptsRoot
instead, as we can verify thestatus
of the receipt on the target subnet to find out if the transaction was executed successfully on the source subnet, before executing it on the target subnet.Fixes TP-654, TP-655
Additions and Changes
receiptRoot
in theCertificate
structure inIToposCore.sol
sendToken
function in theERC20Messaging.sol
contractexecute
and the corresponding_execute
functions in theToposMessaging.sol
andERC20Messaging.sol
contractsBug fixes
erc20MessagingContract
in theToposMessaging.test.ts
PR Checklist: