Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sse error handling #47

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix: sse error handling #47

merged 1 commit into from
Feb 13, 2024

Conversation

sebastiendan
Copy link
Member

Description

This PR fixes SSE error handling by verifying that the error is an application one in the first place. Additionally, the details of the error are now displayed on the Frontend (instead of only being sent to Tempo).

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@sebastiendan sebastiendan self-assigned this Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (19286dd) 85.77% compared to head (0f7db7d) 85.72%.

Files Patch % Lines
packages/frontend/src/hooks/useExecutorService.ts 29.54% 31 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   85.77%   85.72%   -0.06%     
==========================================
  Files          27       27              
  Lines        1378     1380       +2     
  Branches      127      127              
==========================================
+ Hits         1182     1183       +1     
- Misses        196      197       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastiendan sebastiendan merged commit 3ba0228 into main Feb 13, 2024
5 of 6 checks passed
@sebastiendan sebastiendan deleted the fix/sse-error-handling branch February 13, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant