add support for source schema and exclude/include pattern and fix numeric type cast #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@toothrot remake the pr and added the spec need some help to get the spec to pass. |
|
Sorry for the delay, I will look at this shortly. |
|
No matter, thanks. |
toothrot
reviewed
Mar 16, 2018
spec/features/small_table_spec.rb
Outdated
| after(:all) do | ||
| PostgresToRedshift::Test.test_connection.exec(%q[DROP TABLE IF EXISTS "p2r_integration";]) | ||
| PostgresToRedshift::Test.test_target_connection.exec(%q[DROP TABLE IF EXISTS "p2r_integration";]) | ||
|
|
toothrot
reviewed
Mar 16, 2018
README.md
Outdated
| export S3_DATABASE_EXPORT_ID='yourid' | ||
| export S3_DATABASE_EXPORT_KEY='yourkey' | ||
| export S3_DATABASE_EXPORT_BUCKET='some-bucket-to-use' | ||
| export DROP_TABLE_BEFORE_CREATE = true | ||
| export POSTGRES_TO_REDSHIFT_EXCLUDE_TABLE_PATTERN = 'table-pattern-to-exclude1,table-pattern-to-exclude2' |
There was a problem hiding this comment.
Maybe comment here that all tables are included by default?
README.md
Outdated
| export S3_DATABASE_EXPORT_ID='yourid' | ||
| export S3_DATABASE_EXPORT_KEY='yourkey' | ||
| export S3_DATABASE_EXPORT_BUCKET='some-bucket-to-use' | ||
| export DROP_TABLE_BEFORE_CREATE = true |
There was a problem hiding this comment.
Also worth mentioning that this is false by default
| ```bash | ||
| export POSTGRES_TO_REDSHIFT_SOURCE_URI='postgres://username:password@host:port/database-name' | ||
| export POSTGRES_TO_REDSHIFT_TARGET_URI='postgres://username:password@host:port/database-name' | ||
| export POSTGRES_TO_REDSHIFT_TARGET_SCHEMA='testing-data' | ||
| export POSTGRES_TO_REDSHIFT_SOURCE_SCHEMA='testing-data' |
There was a problem hiding this comment.
Worth mentioning that this is 'public' by default
|
@toothrot just updated the readme added a bunch of notes |
|
@dingn1 The env var docs you added include spaces between export DROP_TABLE_BEFORE_CREATE = trueShould be export DROP_TABLE_BEFORE_CREATE=true |
dingn1
changed the title
|
@toothrot bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to specify source schema.Also added a way to only run for certain tables and only exclude certain tables. also fixed #26