Occasionally recycle Postgres source connections #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* postgres_to_redshift.rb (PostgresToRedshift#copy_table): Call PG::Conection.reset after uploading a file to S3.
|
Merging this, but we definitely need to figure out whats happening here. I'll try generating a big data set and playing with the Simply Monthly Calculator to see how much it costs :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #16, I try reopening fresh connections with this change after uploading a file to S3. It is a useful change, since uploading a file could take a while, and the connection could become stale. I've found it makes the script progress further with the larger tables, but the same error will still happen.
According to the documentation for PG::Connection, the
resetmethod:This fix is a stopgap for some large tables, but the code will need a refactor to successfully handle really large tables.