Add emissary ingress CRD #123
Open
+86
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommy351
reviewed
Apr 28, 2023
| @@ -0,0 +1,48 @@ | |||
| { | |||
| "name": "@kubernetes-models/emissary-ingress", | |||
| "version": "3.6.0", | |||
There was a problem hiding this comment.
Suggested change
| "version": "3.6.0", | |
| "version": "0.0.0", |
There was a problem hiding this comment.
Oh, should this version not match the version that is provided in the CRDs? That was my understanding of it
There was a problem hiding this comment.
The version doesn't reflect the CRD version.
Co-authored-by: Tommy Chen <[email protected]>
|
@alexbowers are you still interested in this? If not, I could also take a look as part of a hacktoberfest contribution. |
|
Yes, for now we have a backyard solution in place
…________________________________
From: Christoph Jerolimov ***@***.***>
Sent: Tuesday, October 24, 2023 7:28:49 AM
To: tommy351/kubernetes-models-ts ***@***.***>
Cc: Alex Bowers ***@***.***>; Mention ***@***.***>
Subject: Re: [tommy351/kubernetes-models-ts] Add emissary ingress CRD (PR #123)
@alexbowers<https://github.com/alexbowers> are you still interested in this? If not, I could also take a look as part of a hacktoberfest contribution.
—
Reply to this email directly, view it on GitHub<#123 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAGNZXV6JTALB6GZDFQSMJLYA5N2DAVCNFSM6AAAAAAXO55GEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZWGYYDKNZRGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Sorry, I need more clarity. You are interested, but will you update the PR based on the feedback (version number, readme, tests), or should I try to open a new one? |
|
To be honest, I don't actually use Kubernetes Models TS anymore, i've instead moved to using CDK8s; so feel free to take this on, or close the PR and make your own |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.