Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auto-tracker): Add auto tracking capability to extension #2302

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

with-shrey
Copy link
Contributor

Please remember the Contributing Guidelines ❤️

🌟 What does this PR do?

🐛 Recommendations for testing

All changes should be tested across Chrome and Firefox.

📝 Links to relevant issues or information

@with-shrey
Copy link
Contributor Author

I dont have heap access @izontm

Please share top 10 integration list so we can validate for them

@izontm
Copy link
Contributor

izontm commented Sep 27, 2024

@with-shrey for the last 7 days
Sorry, I didn't have time to test it; I can try next week if not tomorrow.
image

Copy link
Contributor

@askides askides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing i wanted to be sure about.

Rest is LGTM.

{ observe: true },
function (elem) {
if (!elem) return;
setTimeout(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the setTimeout here? Does the debounceInterval set to 2000 does not work?

Copy link
Contributor Author

@with-shrey with-shrey Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesnt do it for the first render

@with-shrey with-shrey merged commit 4f45508 into master Sep 30, 2024
1 check passed
@with-shrey with-shrey deleted the feat/auto-tracker branch September 30, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants