shell.nix: update deps, add jlink #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the 24.05 nixpkgs release, we should be good to add jlink back. I have added necessary deps uncrustify and unzip. Decompressing newlib fails and tries to reinstall every time if `unzip` is unavailable.
alevy
reviewed
Jun 20, 2024
| # | ||
| # [1]: https://github.com/NixOS/nixpkgs/pull/255185 | ||
| uncrustify | ||
| unzip |
There was a problem hiding this comment.
These are good, though uncrustify in 24.05 is a newer version than the one libtock-c's tools expect, and as a result, ./formal_all.sh sill builds it from source.
alevy
reviewed
Jun 20, 2024
| uncrustify | ||
| unzip | ||
| ] ++ (lib.optionals withUnfreePkgs [ | ||
| segger-jlink |
There was a problem hiding this comment.
Ugh... it still requires export NIXPKGS_ALLOW_INSECURE=1 because JLink relies on some ancient version of Qt. Fine...
alevy
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
With the 24.05 nixpkgs release, we should be good to add jlink back. I have added necessary deps uncrustify and unzip. Decompressing newlib fails (silently) and tries to reinstall every time if
unzipis unavailable.Testing Strategy
Built all examples successfully.
CC: @lschuermann