Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify client and server certificate selection text #1361

Merged
merged 4 commits into from
Jul 7, 2024

Conversation

davidben
Copy link
Contributor

I noticed this as I was looking for where we officially wrote down the implications of the X.509 Key Usage extension. We wrote it down for the server, but forgot to for the client.

The root issue is that we unified certificate negotiation in TLS 1.3 (ClientHello/Certificate and CertificateRequest/Certificate are now nice and symmetric), but forgot to correspondingly unify some of this prose. As a result, we said the same thing in different ways, and forgot different things in either place.

This change merges the two.

I noticed this as I was looking for where we officially wrote down the
implications of the X.509 Key Usage extension. We wrote it down for the
server, but forgot to for the client.

The root issue is that we unified certificate negotiation in TLS 1.3
(ClientHello/Certificate and CertificateRequest/Certificate are now nice
and symmetric), but forgot to correspondingly unify some of this prose.
As a result, we said the same thing in different ways, and forgot
different things in either place.

This change merges the two.
Copy link

@ilucas39 ilucas39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

◢💙◣ ◢💖◣
💙💙💙◣ ◢💖💖💖
◥💙💙💙💖💖💖◤
◥💙💙💖💖◤
◥💙💖◤
◥ ◤

@ekr ekr merged commit 976551d into tlswg:main Jul 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants