-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tinygo: add relative and absolute --dir options to wasmtime args #4431
tinygo: add relative and absolute --dir options to wasmtime args #4431
Conversation
I think there is some code in the waisp1 or wasip2 branch that detects "something" (will need to double check) based on the first or last --dir option provided. Are we breaking anything else by effectively having two names for each directory in the module path here? |
It worked for the tests I ran. Did you discover anything? |
No, I was just wondering because I know I had issues with argument ordering. I didn't see any failures, but I can run my larger test corpus and see what falls out. |
@ydnar did you get any further with this PR? |
I haven't. I'll try that! |
75ae352
to
0743587
Compare
@ydnar looks like CI still failing here: Possible timeout? |
0743587
to
2aa50b4
Compare
Is there a timeout or OOM issue related to the GitHub Actions runner?
This reverts commit c0f6431.
Looks like a logic error on my part. Fixed! I wanted |
@ydnar LGTM do you want to squash these commits yourself, or would you prefer that I do it for you? |
Is squash merge okay? |
Done. Thank you very much! |
…ygo-org#4431) main: add relative and absolute --dir options to wasmtime args
This normalizes the
--dir
arguments passed towasmtime
for bothwasip1
andwasip2
when runningtinygo test
ortinygo run
. The additional--dir
andPWD
arguments will now be reflected when using-x
.