nina: BLE implementation on nina-fw #207

deadprogram · 2023-12-20T22:39:13Z

This PR is to start adding a BLE implementation for boards that use the nina-fw on a connected co-processor.

The only board so far in this PR is the nano-rp2040.

$ tinygo flash -size=short -target=nano-rp2040 -monitor ./examples/scanner
   code    data     bss |   flash     ram
  10824     152    3296 |   10976    3448
Connected to /dev/ttyACM0. Press Ctrl-C to exit.
scanning...
found device: 69:C0:49:32:5B:A5 -94 
found device: 69:C0:49:32:5B:A5 -94 
...

There is still a lot more needed to get an initial implementation complete as a central, but this hopefully is a good starting point.

aykevl

Great work! Overall looking good.

Quick review, focusing mostly on the public API. I haven't really looked at the implementation, assuming you're going to test that one :) (and I don't know much about this BLE firmware anyway).

adapter_nina.go

att.go

debug.go

gap_nina.go

gattc_nina.go

hci.go

gattc_nina.go

deadprogram · 2023-12-29T10:02:35Z

Making progress:

$ tinygo flash -size short -target nano-rp2040 -tags "ninafw" -monitor -ldflags="-X main.DeviceAddress=57:91:FE:33:10:DC" ./examples/discover/                               
   code    data     bss |   flash     ram                                                                                                                                    
  23504     248    3300 |   23752    3548                                                                                                                                    
Connected to /dev/ttyACM0. Press Ctrl-C to exit.                                                                                                                             
enabling                                                                                                                                                                     
scanning...                                                                                                                                                                  
found device: 42:58:16:B6:05:FB -78                                                                                                                                          
found device: 4C:79:58:04:F5:26 -78                                                                                                                                          
found device: 57:91:FE:33:10:DC -83 Pixel 4a                                                                                                                                 
connected to  57:91:FE:33:10:DC                                                                                                                                              
discovering services/characteristics                                                                                                                                         
- service 01181400-1a00-0018-8600-8d000d180000               
- service 00188600-8d00-0d18-0000-000000000000
- service 0d180000-0000-0000-0000-000000000000
- service ffeeddcc-bbaa-0080-0010-0000a0aa0000
- service 1c180000-0000-0000-0000-000000000000              
Done.

deadprogram · 2023-12-29T16:34:13Z

Actually my code for the UUIDs for nina was incorrect. However, now I also can discover characteristics 😸

$ tinygo flash -size short -target nano-rp2040 -monitor -ldflags="-X main.DeviceAddress=61:8B:6F:C7:47:68" ./examples/discover/                                                                                                                                                                                              
   code    data     bss |   flash     ram                                                                                                         
  25040     256    3300 |   25296    3556                                                                                                         
Connected to /dev/ttyACM0. Press Ctrl-C to exit.                                                                                                  
enabling                                                                                                                                          
scanning...                                                                                                                                       
found device: 67:EA:32:CA:33:DC -76                                                                                                               
found device: 67:EA:32:CA:33:DC -82                                                                                                               
found device: 61:8B:6F:C7:47:68 -85 Pixel 4a                                                                                                      
connected to  61:8B:6F:C7:47:68                                                                                                                   
discovering services/characteristics                                                                                                              
- service 00001801-0000-1000-8000-00805f9b34fb                                                                                                    
-- characteristic 00002a05-0000-1000-8000-00805f9b34fb                                                                                            
    data bytes 0                                                                                                                                  
    value =                                                                                                                                       
-- characteristic 00002b3a-0000-1000-8000-00805f9b34fb                                                                                            
    data bytes 0                                                                                                                                  
    value =                                                                                                                                       
-- characteristic 00002b29-0000-1000-8000-00805f9b34fb                                                                                            
    data bytes 0                                                                                                                                  
    value =                                                                                                                                       
-- characteristic 00002b2a-0000-1000-8000-00805f9b34fb                                                                                            
    data bytes 0                                                                                                                                  
    value =                                                                                                                                       
- service 00001800-0000-1000-8000-00805f9b34fb                                                                                                                
-- characteristic 00002a00-0000-1000-8000-00805f9b34fb
    data bytes 0                                                                      
    value =     
-- characteristic 00002a01-0000-1000-8000-00805f9b34fb                                                                                                        
    data bytes 0                                                                      
    value =     
-- characteristic 00002aa6-0000-1000-8000-00805f9b34fb                                                                                                        
    data bytes 0                                                                      
    value =                                                                                              
- service 0000180d-0000-1000-8000-00805f9b34fb                                                                                                                
-- characteristic 00002a37-0000-1000-8000-00805f9b34fb                                                                 
    data bytes 0                                                                                         
    value =                                         
-- characteristic 00002a38-0000-1000-8000-00805f9b34fb                                                                                                        
    data bytes 0                                                                                         
    value =                                                
-- characteristic 00002a39-0000-1000-8000-00805f9b34fb                                                                                                        
    data bytes 0                                                                                                       
    value =                                                                                                            
- service 0000aaa0-0000-1000-8000-aabbccddeeff                                                                                                                
-- characteristic 0000aaa1-0000-1000-8000-aabbccddeeff                                                                                                        
    data bytes 0                                                                                                       
    value =                                                
-- characteristic 0000aaa2-0000-1000-8000-aabbccddeeff                                                                                                        
    data bytes 0                                                                                                       
    value =                                                                    
- service 0000181c-0000-1000-8000-00805f9b34fb                                                                                                                
-- characteristic 00002a8a-0000-1000-8000-00805f9b34fb                                                                                                        
    data bytes 0                                                               
    value =                                                                    
-- characteristic 00002a90-0000-1000-8000-00805f9b34fb                                                                                                        
    data bytes 0                                                               
    value =                                                                    
-- characteristic 00002a8c-0000-1000-8000-00805f9b34fb                                                                                                        
    data bytes 0                                                               
    value =                                                                    
Done.

deadprogram · 2023-12-29T16:57:13Z

This PR is now ready for further review/merge. @aykevl I have addressed your previous comments.

deadprogram · 2023-12-30T08:20:35Z

OK, now I also can Read characteristic values:

$ tinygo flash -size short -target nano-rp2040 -monitor -ldflags="-X main.DeviceAddress=40:C4:BE:56:BE:63" ./examples/discover/                                                                                    
   code    data     bss |   flash     ram                                                                                                                                                                          
  26620     272    3300 |   26892    3572                                                                                                                                                                          
Connected to /dev/ttyACM0. Press Ctrl-C to exit.                                                                                                                                                                   
enabling                                                                                                 
scanning...                                                                                                                                                                                                        
found device: 40:C4:BE:56:BE:63 -78 Pixel 4a                                                             
connected to  40:C4:BE:56:BE:63                                                                                                                                                                                    
discovering services/characteristics                                                                     
- service 00001801-0000-1000-8000-00805f9b34fb                                                                                                                                                                     
-- characteristic 00002a05-0000-1000-8000-00805f9b34fb                                                   
     bluetooth: read not supported                                                                       
-- characteristic 00002b3a-0000-1000-8000-00805f9b34fb                                                   
    data bytes 1                                    
    value =                                                                                              
-- characteristic 00002b29-0000-1000-8000-00805f9b34fb                                                   
    data bytes 1                                                                                         
    value =                                                                                              
-- characteristic 00002b2a-0000-1000-8000-00805f9b34fb                                                                                                                                                             
    data bytes 16                                                                                                                                                                                                  
    value = DLtLk                                                                                        
- service 00001800-0000-1000-8000-00805f9b34fb                                                                                                                                                                     
-- characteristic 00002a00-0000-1000-8000-00805f9b34fb                                                   
    data bytes 8                                                                                         
    value = Pixel 4a                                                                                                                                                                                               
-- characteristic 00002a01-0000-1000-8000-00805f9b34fb                                                                                                                                                             
    data bytes 2                                                                                                                                                                                                   
    value =                                                                                                                                                                                                        
-- characteristic 00002aa6-0000-1000-8000-00805f9b34fb                                                   
    data bytes 1                                                                                                                                                                                                   
    value =                                                                                                                                                                                                        
- service 0000180d-0000-1000-8000-00805f9b34fb                                                           
-- characteristic 00002a37-0000-1000-8000-00805f9b34fb                                                                                                                                                             
     bluetooth: read not supported                                                                                                                                                                                 
-- characteristic 00002a38-0000-1000-8000-00805f9b34fb                                                                                                                                                             
    data bytes 1                                                                                                                                                                                                   
    value =                                                                                                                                                                                                        
-- characteristic 00002a39-0000-1000-8000-00805f9b34fb                                                   
     bluetooth: read not supported                                                                                                                                                                                 
- service 0000aaa0-0000-1000-8000-aabbccddeeff                                                                                                                                                                     
-- characteristic 0000aaa1-0000-1000-8000-aabbccddeeff                                                                                                                                                             
    data bytes 2                                                                                                                                                                                                   
    value =                                                                                                                                                                                                        
-- characteristic 0000aaa2-0000-1000-8000-aabbccddeeff                                                                                                                                                             
     bluetooth: read not supported                                                                                                                                                                                 
- service 0000181c-0000-1000-8000-00805f9b34fb                                                                                                                                                                     
-- characteristic 00002a8a-0000-1000-8000-00805f9b34fb                                                   
    data bytes 9                                                                                                                                                                                                   
    value = Natenczas                                                                                                                                                                                              
-- characteristic 00002a90-0000-1000-8000-00805f9b34fb                                                                 
    data bytes 6                                           
    value = Wojski                                         
-- characteristic 00002a8c-0000-1000-8000-00805f9b34fb                                                                 
    data bytes 1                                           
    value =                                                
Done.

deadprogram · 2024-01-03T14:00:31Z

After a fair bit of effort, can now receive notifications on characteristics:

$ tinygo flash -size short -target nano-rp2040 -monitor -ldflags="-X main.DeviceAddress=5C:DF:97:1D:E4:00" ./examples/heartrate-monitor/
   code    data     bss |   flash     ram
  29252     300    3300 |   29552    3600
Connected to /dev/ttyACM0. Press Ctrl-C to exit.
scanning...
found device: 88:C6:26:9D:A2:56 -79 
found device: 5C:DF:97:1D:E4:00 -72 Pixel 4a
connected to  5C:DF:97:1D:E4:00
discovering services/characteristics
found service 0000180d-0000-1000-8000-00805f9b34fb
found characteristic 00002a37-0000-1000-8000-00805f9b34fb
data: 90
data: 90
data: 90
data: 91
data: 91
data: 92
data: 92

aykevl

Looks good, nothing too major.

I haven't reviewed the implementation very thoroughly, I've looked mostly at the API and consistency with other implementations.

Makefile

adapter_ninafw.go

att_ninafw.go

debug.go

gap_ninafw.go

gattc_ninafw.go

deadprogram · 2024-01-03T19:36:13Z

I have squashed this down to 2 commits, and rebased against the latest dev. I think it is basically ready enough to merge.

deadprogram · 2024-01-03T20:02:37Z

@aykevl I ended up adding a commit to this PR to remove some pointer receivers after all.

Signed-off-by: deadprogram <[email protected]>

aykevl

🎉

deadprogram force-pushed the nina-ble branch from 84fe50c to 6c21643 Compare December 20, 2023 22:54

bgould mentioned this pull request Dec 21, 2023

Support Arduino nina-fw #70

Closed

aykevl reviewed Dec 27, 2023

View reviewed changes

deadprogram force-pushed the nina-ble branch from 480b4f8 to 35ad371 Compare December 28, 2023 10:55

deadprogram marked this pull request as ready for review December 29, 2023 16:51

deadprogram force-pushed the nina-ble branch from 8fd6f7d to 539631c Compare December 29, 2023 17:06

deadprogram force-pushed the nina-ble branch from 94487c5 to 624a9f9 Compare January 2, 2024 15:42

aykevl reviewed Jan 3, 2024

View reviewed changes

deadprogram mentioned this pull request Jan 3, 2024

targets: add ninafw tag to nano-rp2040 for ninafw BLE support tinygo-org/tinygo#4069

Merged

deadprogram force-pushed the nina-ble branch from bf6dfce to 95c538e Compare January 3, 2024 19:34

deadprogram force-pushed the nina-ble branch 2 times, most recently from 9c9f594 to 1a90b00 Compare January 3, 2024 19:48

deadprogram added 4 commits January 3, 2024 22:09

ninafw: BLE central implementation on nina-fw co-processors

7de74ef

Signed-off-by: deadprogram <[email protected]>

docs: a small mention of the NINA BLE support

162a357

Signed-off-by: deadprogram <[email protected]>

ninafw: remove some pointer receivers from method calls

49d5ff0

Signed-off-by: deadprogram <[email protected]>

ninafw: implement GetMTU()

e874524

Signed-off-by: deadprogram <[email protected]>

deadprogram force-pushed the nina-ble branch from 7c9b2e4 to e874524 Compare January 3, 2024 21:14

build: add some ninafw examples to smoketest

6aed422

Signed-off-by: deadprogram <[email protected]>

aykevl approved these changes Jan 4, 2024

View reviewed changes

aykevl merged commit b8a4a54 into dev Jan 4, 2024
5 checks passed

aykevl deleted the nina-ble branch January 4, 2024 13:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nina: BLE implementation on nina-fw #207

nina: BLE implementation on nina-fw #207

deadprogram commented Dec 20, 2023

aykevl left a comment •

edited

Loading

deadprogram commented Dec 29, 2023

deadprogram commented Dec 29, 2023

deadprogram commented Dec 29, 2023

deadprogram commented Dec 30, 2023

deadprogram commented Jan 3, 2024

aykevl left a comment

deadprogram commented Jan 3, 2024 •

edited

Loading

deadprogram commented Jan 3, 2024

aykevl left a comment

nina: BLE implementation on nina-fw #207

nina: BLE implementation on nina-fw #207

Conversation

deadprogram commented Dec 20, 2023

aykevl left a comment • edited Loading

Choose a reason for hiding this comment

deadprogram commented Dec 29, 2023

deadprogram commented Dec 29, 2023

deadprogram commented Dec 29, 2023

deadprogram commented Dec 30, 2023

deadprogram commented Jan 3, 2024

aykevl left a comment

Choose a reason for hiding this comment

deadprogram commented Jan 3, 2024 • edited Loading

deadprogram commented Jan 3, 2024

aykevl left a comment

Choose a reason for hiding this comment

aykevl left a comment •

edited

Loading

deadprogram commented Jan 3, 2024 •

edited

Loading