Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add Windows to GH actions build jobs #191

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

deadprogram
Copy link
Member

This PR adds Windows to the GH actions build jobs.

@deadprogram
Copy link
Member Author

Any comments before I merge?

@deadprogram
Copy link
Member Author

Now merging to run this as part of CI.

@deadprogram deadprogram merged commit 20ccbeb into dev Aug 29, 2023
3 checks passed
@deadprogram deadprogram deleted the gh-action-windows branch August 29, 2023 20:57
Copy link
Member

@aykevl aykevl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are already tested under Linux (using mingw). Perhaps we can remove those tests? Testing under the real operating system will always be better.

@deadprogram
Copy link
Member Author

These are already tested under Linux (using mingw). Perhaps we can remove those tests? Testing under the real operating system will always be better.

The only reason I did not remove them, was that it demonstrated how to do cross-compilation for Windows with bluetooth package, and that the compilation actually is working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants