Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme improvements #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lucaboesch
Copy link
Contributor

Show the README.md page with some pills.

@timhunt
Copy link
Owner

timhunt commented Jan 8, 2024

Why is the change LICENSE.md -> LICENSE good?

It is confusing to add a Behat test in this commit / pull request. Should that be submitted separately? (It is a good test - except I would have it run on all Moodle versions, to show that the expected behaviour in this scenario has not changed - I don't see why there are currently two scenarios. And, if you need a comment as the first thing in a scenario, you should probably improve the scenario name instead.)

@lucaboesch
Copy link
Contributor Author

In order to make the license pill [![License GPL-3.0](https://img.shields.io/github/license/timhunt/moodle-availability_quizquestion?color=lightgrey)](https://github.com/timhunt/moodle-availability_quizquestion/blob/main/LICENSE)
working in my experience. It wouldn't work with LICENSE.md. See studentquiz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants