Make cost-based decision about partial aggregation paths #7052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we just remove all existing paths, but after that we add a hash aggregation path (ts_plan_add_hashagg()) which we can prefer based on the cost, which leads to weird behavior.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7052 +/- ##
==========================================
+ Coverage 80.06% 81.78% +1.71%
==========================================
Files 190 200 +10
Lines 37181 37232 +51
Branches 9450 9702 +252
==========================================
+ Hits 29770 30450 +680
+ Misses 2997 2878 -119
+ Partials 4414 3904 -510 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we just remove all existing paths, but after that we add a hash aggregation path (ts_plan_add_hashagg()) which we can prefer based on the cost, which leads to weird behavior.