Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tsconfig to webpack #1

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Tsconfig to webpack #1

wants to merge 17 commits into from

Conversation

t754
Copy link
Contributor

@t754 t754 commented Dec 2, 2019

clasp の tsconfig -> webpack&babel化した.
合わせて clasp pull でフォーマットされたコードに合わせている.

src/Property.ts Outdated
export const ONE = getProp('ONE');
export const TWO = getProp('TWO');
export const THREE = getProp('THREE');
export const RAIN = getProp('RAIN');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ONE~RAIN はやりすぎ感あるw

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(i18n化も視野にいれて別にしてみました(大嘘))
普通に一回しか使わないし,即値で良さそうですね. 直します.

@t754
Copy link
Contributor Author

t754 commented Dec 19, 2019

なおした & code fomat .
加えて 連想配列のkey に当たるところ型を定義(category)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants