Check time spent on attempting RPC to avoid spending too much time on retrying #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… retrying Signed-off-by: MyonKeminta <[email protected]>
|
I'm still considering whether the values passed to these |
Signed-off-by: MyonKeminta <[email protected]>
…id-too-much-rpc-retry-on-timeout
Signed-off-by: MyonKeminta <[email protected]>
|
PTAL while I'm testing how it works in a real cluster with io injection |
zyguan
reviewed
Jan 17, 2024
internal/locate/region_request.go
Outdated
| @@ -2396,3 +2419,10 @@ func (s *replicaSelector) patchRequestSource(req *tikvrpc.Request, rpcCtx *RPCCo | |||
| } | |||
| sb.WriteString(req.ReadType) | |||
| } | |||
|
|
|||
| func (s *replicaSelector) recordAttemptedTime(duration time.Duration) { | |||
| s.targetReplica().attemptedTime += duration | |||
There was a problem hiding this comment.
Maybe check s.targetReplica() != nil, otherwise the method is required to be called at right place.
|
I didn't finish testing it due to not yet successfully allocate resources for testing 😥 shall we consider merging it first? |
Signed-off-by: MyonKeminta <[email protected]>
zyguan
approved these changes
Jan 18, 2024
cfzjywxk
approved these changes
Jan 18, 2024
lance6716
pushed a commit
to lance6716/client-go
that referenced
this pull request
Jan 22, 2024
… retrying (tikv#1117) * Check time spent on attempting RPC to avoid spending too much time on retrying Signed-off-by: MyonKeminta <[email protected]> * Handle refreshRegionStore Signed-off-by: MyonKeminta <[email protected]> * Add test Signed-off-by: MyonKeminta <[email protected]> * Address comments Signed-off-by: MyonKeminta <[email protected]> --------- Signed-off-by: MyonKeminta <[email protected]> Co-authored-by: MyonKeminta <[email protected]> Signed-off-by: lance6716 <[email protected]>
13 tasks
This was referenced Jan 23, 2024
MyonKeminta
added a commit
to MyonKeminta/client-go
that referenced
this pull request
Jan 24, 2024
… retrying (tikv#1117) * Check time spent on attempting RPC to avoid spending too much time on retrying Signed-off-by: MyonKeminta <[email protected]> * Handle refreshRegionStore Signed-off-by: MyonKeminta <[email protected]> * Add test Signed-off-by: MyonKeminta <[email protected]> * Address comments Signed-off-by: MyonKeminta <[email protected]> --------- Signed-off-by: MyonKeminta <[email protected]> Co-authored-by: MyonKeminta <[email protected]>
disksing
pushed a commit
that referenced
this pull request
Jan 24, 2024
… retrying (#1117) (#1131) Signed-off-by: MyonKeminta <[email protected]> Co-authored-by: MyonKeminta <[email protected]>
MyonKeminta
added a commit
to MyonKeminta/client-go
that referenced
this pull request
Jan 24, 2024
… time on retrying (tikv#1117) (tikv#1131)" This reverts commit 062f4c9. Signed-off-by: MyonKeminta <[email protected]>
cfzjywxk
pushed a commit
that referenced
this pull request
Jan 24, 2024
… time on retrying (#1117) (#1131)" (#1133) This reverts commit 062f4c9. Signed-off-by: MyonKeminta <[email protected]> Co-authored-by: MyonKeminta <[email protected]>
ti-chi-bot
added
the
needs-cherry-pick-release-7.5
MyonKeminta
added a commit
to MyonKeminta/client-go
that referenced
this pull request
Feb 19, 2024
… retrying (tikv#1117) * Check time spent on attempting RPC to avoid spending too much time on retrying Signed-off-by: MyonKeminta <[email protected]> * Handle refreshRegionStore Signed-off-by: MyonKeminta <[email protected]> * Add test Signed-off-by: MyonKeminta <[email protected]> * Address comments Signed-off-by: MyonKeminta <[email protected]> --------- Signed-off-by: MyonKeminta <[email protected]> Co-authored-by: MyonKeminta <[email protected]>
ti-chi-bot
removed
the
needs-cherry-pick-release-7.5
ti-chi-bot
added
needs-cherry-pick-release-6.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref pingcap/tidb#50432