Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/qemu #1297

Closed
wants to merge 3 commits into from
Closed

Fix/qemu #1297

wants to merge 3 commits into from

Conversation

hakuturu583
Copy link
Collaborator

@hakuturu583 hakuturu583 commented Jun 21, 2024

Description

Please check examples and comment out this sentence. Minimal example is here and detailed example is here

Abstract

[Required] This section is required, keep it short, clear and to the point.
Delete this sentence and explain this pull request shortly.

Background

[Optional] If there is no background information that needs explanation (e.g., just a typo correction, etc.), you can skip this section.
Delete this sentence and explain the circumstances that led to this pull request being sent.

Details

[Optional] If there are only differences whose effects are so obvious that no explanation is needed, or if there are no differences in the code (e.g., documentation additions), you can skip this section.
Delete this sentence and describe this pull request.
For example, it is desirable to describe the specifications of added functions, and detailed explanations of bugs that have been fixed.

References

#1296

Destructive Changes

N/A

Known Limitations

N/A

@hakuturu583 hakuturu583 added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Jun 21, 2024
@hakuturu583 hakuturu583 self-assigned this Jun 21, 2024
Copy link

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

Signed-off-by: Masaya Kataoka <[email protected]>
@hakuturu583 hakuturu583 deleted the fix/qemu branch June 21, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant