-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nebula_decoders_hesai) unify pointcloud order and filtering of all sensors #56
Commits on Aug 21, 2023
-
Fix XT32 always checking points against 1st block
The XT32 decoder, in dual return mode, employs a check whether the two returned points are identical. The way the point for comparison was indexed was erroneous and ended up always being the 1st or 2nd block of the packet, although there are a total of 8 blocks.
Configuration menu - View commit details
-
Copy full SHA for fe2905f - Browse repository at this point
Copy the full SHA fe2905fView commit details -
Include dual_return_distance_threshold when printing HesaiSensorConfig
This field was missing earlier, leading to avoidable troubleshooting.
Configuration menu - View commit details
-
Copy full SHA for 24b756a - Browse repository at this point
Copy the full SHA 24b756aView commit details -
Fix dual return check ignoring some modes in XT32 decoder
The XT32 decoder did not classify First+Last, First+Strongest as dual return in its check. Added the return mode constants to the header and to the check
Configuration menu - View commit details
-
Copy full SHA for 2957e88 - Browse repository at this point
Copy the full SHA 2957e88View commit details -
Change 40P output order from firing time to logical order
The Pandar40P decoder decoded points in firing time order. Since all other sensors use logical ordering (by ascending index), Pandar40P is adapted to this convention.
Configuration menu - View commit details
-
Copy full SHA for 0a4541a - Browse repository at this point
Copy the full SHA 0a4541aView commit details -
Increase Pandar40P distance accuracy
LASER_RETURN_DISTANCE was defined as float, is now double. This brings Pandar40P distance accuracy up to the level of all other sensors, which calculate distance on the fly in higher precision.
Configuration menu - View commit details
-
Copy full SHA for d19bfc4 - Browse repository at this point
Copy the full SHA d19bfc4View commit details -
Adapt XT32M output order and scan completion check
Other sensors output in `return_group > channel > block` order, the XT32M decoder was outputting `block > channel`. The XT32M scan completion check involved timing checks. These are currently unused and complicate the code. Further, they prevent a generic implementation. Thus, the check has been streamlined.
Configuration menu - View commit details
-
Copy full SHA for 836b9c5 - Browse repository at this point
Copy the full SHA 836b9c5View commit details -
Implement/fix distance checks in Hesai decoders
Fixes tier4#49, fixes tier4#48. Multiple decoders (QT64, QT128, 64, XT32, 128) had distance checks using comparison operators different to the other sensors (e.g. `>` instead of `>=`). Pandar40P had no min_range / max_range checks. AT128, XT32, XT32M had no dual_return_threshold checks. Identical points were not removed when dual_return_distance_threshold = 0. All of these checks are corrected/added with this commit.
Configuration menu - View commit details
-
Copy full SHA for 47dcb4e - Browse repository at this point
Copy the full SHA 47dcb4eView commit details
Commits on Aug 22, 2023
-
Remove imprecise XT32M sin/cos tables
The sin/cos azimuth lookup tables did not include the channel-wise azimuth offset in their calculation, leading to up to 0.166 deg of azimuth error in the output X/Y values. The tables have been replaced with sinf/cosf calls.
Configuration menu - View commit details
-
Copy full SHA for 7934b7d - Browse repository at this point
Copy the full SHA 7934b7dView commit details -
Add
return_distance_threshold = 0.1
to unit testsUnit tests for Hesai decoders were not setting `dual_return_distance_threshold` at all, causing it to be `0` implicitly. This caused a large number of duplicate points to be output by the decoders. The distance is set to `0.1 [m]` for all Hesai sensors now, which is the default in the Hesai launch file.
Configuration menu - View commit details
-
Copy full SHA for 16d90c9 - Browse repository at this point
Copy the full SHA 16d90c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0f5422 - Browse repository at this point
Copy the full SHA a0f5422View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ee86a5 - Browse repository at this point
Copy the full SHA 4ee86a5View commit details