Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update velodyne point stamp calculation #47

Merged
merged 5 commits into from
Aug 8, 2023
Merged

Conversation

amc-nu
Copy link
Contributor

@amc-nu amc-nu commented Aug 8, 2023

PR Type

  • Bug Fix

Related Links

Description

Fixes Autoware points point independent timestamp calculation.

@amc-nu amc-nu requested a review from drwnz August 8, 2023 03:36
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: +2.78% 🎉

Comparison is base (189d7e2) 13.38% compared to head (8ab8d58) 16.17%.
Report is 1 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   13.38%   16.17%   +2.78%     
==========================================
  Files         111       54      -57     
  Lines       10990     8674    -2316     
  Branches     1727     1711      -16     
==========================================
- Hits         1471     1403      -68     
+ Misses       8338     6094    -2244     
+ Partials     1181     1177       -4     
Flag Coverage Δ
differential 16.17% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
nebula_common/src/nebula_common.cpp 0.00% <0.00%> (ø)
...ebula_ros/hesai/hesai_hw_interface_ros_wrapper.hpp 0.00% <ø> (ø)
.../nebula_ros/hesai/hesai_hw_monitor_ros_wrapper.hpp 0.00% <ø> (ø)
...ula_ros/src/hesai/hesai_hw_monitor_ros_wrapper.cpp 0.00% <ø> (ø)
..._ros/src/velodyne/velodyne_decoder_ros_wrapper.cpp 0.00% <0.00%> (ø)

... and 57 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working, solves issues with distortion corrector node in Autoware.

@drwnz drwnz merged commit cb25896 into main Aug 8, 2023
6 of 8 checks passed
@drwnz drwnz deleted the velodyne-aw-points-fix branch August 8, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants