fix(nebula_ros): limit cloud_max_angle param to 359 #44

[mebasoglu]

PR Type

• Bug Fix

Related Links

The issue: #44

Description

This PR changes default cloud_max_angle to 359 and also limits cloud_min_angle and cloud_max_angle to 359. By doing those, it fixes #44 .

Review Procedure

Range of the parameters, default values of them and readme can be checked.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

• Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

• Commits are properly organized and messages are according to the guideline
• (Optional) Unit tests have been written for new behavior
• PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

• All open points are addressed and tracked via issues or tickets

CI Checks

• Build and test for PR: Required to pass before the merge.

[drwnz]

Thank you for the PR! I see you have edited for Hesai and Velodyne - actually, Hesai sensors have a range from [0...360] whereas Velodyne sensors are typically [0...359].

[mebasoglu]

Hello, thank you for the feedback! I discarded Hesai chagnes.

[drwnz]

@mebasoglu cc @amc-nu
Thank you for the PR- upon investigation, unfortunately we can't limit Velodyne max angle to 360 degrees as it is used in software clipping so doing so results in a 1 degree gap in the cloud.
I will address this issue in a different PR.

[codecov-commenter]

Codecov Report

Patch coverage has no change and project coverage change: -2.13% ⚠️

Comparison is base (cb25896) 13.38% compared to head (5cc5164) 11.25%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   13.38%   11.25%   -2.13%     
==========================================
  Files         111       33      -78     
  Lines       10991     4619    -6372     
  Branches     1727     1145     -582     
==========================================
- Hits         1471      520     -951     
+ Misses       8339     3156    -5183     
+ Partials     1181      943     -238     

Flag	Coverage Δ
differential	11.25% <0.00%> (?)
total	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
..._ros/src/velodyne/velodyne_decoder_ros_wrapper.cpp	0.00% <0.00%> (ø)
...src/velodyne/velodyne_hw_interface_ros_wrapper.cpp	0.00% <0.00%> (ø)

... and 78 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[drwnz]

@mebasoglu
Can you please test with this PR?
#50

If that fixes the issue then we can close this PR. Thank you.

[mebasoglu]

Hello, I tested and it works, thank you.