Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nebula): replace pcd with corresponding calib file #34

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

amc-nu
Copy link
Contributor

@amc-nu amc-nu commented Jul 6, 2023

PR Type

  • Bug Fix

Related Links

https://tier4.atlassian.net/browse/RT1-2669

Description

Fix AT128 unsuccessful test

Review Procedure

colcon test --event-handlers console_cohesion+ --packages-above nebula_common

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@427409a). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage        ?   28.65%           
=======================================
  Files           ?       16           
  Lines           ?     1815           
  Branches        ?     1145           
=======================================
  Hits            ?      520           
  Misses          ?      352           
  Partials        ?      943           
Flag Coverage Δ
differential 28.65% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@drwnz drwnz self-requested a review July 6, 2023 09:02
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, passing on a fresh pull of Nebula.
Just a note: you have to make sure any changes to the default correction files are reverted or the tests will fail (for AT128).

@drwnz drwnz merged commit c90e808 into main Jul 6, 2023
8 checks passed
@amc-nu amc-nu deleted the at128_test_fix branch July 10, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants