Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: concatenate all namespaces c++17-style #207

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Oct 3, 2024

PR Type

  • Improvement

Related Links

Description

These changes are auto-applied by Clang-Tidy.
I confirmed all diffs are of the shape (old -> new)

namespace a {
namespace b {
} // b
} // a

->

namespace a::b {
} // a::b

Review Procedure

None necessary if CI passes.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex requested a review from drwnz October 3, 2024 06:36
@mojomex mojomex self-assigned this Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@f43a28d). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #207   +/-   ##
=======================================
  Coverage        ?   25.76%           
=======================================
  Files           ?       99           
  Lines           ?     8755           
  Branches        ?     2203           
=======================================
  Hits            ?     2256           
  Misses          ?     6114           
  Partials        ?      385           
Flag Coverage Δ
differential 25.76% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drwnz drwnz merged commit 668c8f7 into tier4:main Oct 3, 2024
13 of 14 checks passed
@mojomex mojomex deleted the chore/fix-namespace-style branch October 3, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants