Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seyond #167

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Seyond #167

merged 3 commits into from
Jun 26, 2024

Conversation

manato
Copy link
Collaborator

@manato manato commented Jun 25, 2024

PR Type

  • New Feature

Related Links

Description

This PR adds a HW-interface for Seyond sensors. Currently, the implementation supports limited features, such as the return mode settings and PTP profile settings.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

This implementation has limited functions; just starting packet
streaming and enqueue them

Signed-off-by: Manato HIRABAYASHI <[email protected]>
Signed-off-by: Manato HIRABAYASHI <[email protected]>
This implementation supports configuring IEEE1588v2 or gPTP only. PTP
domain, PTP transport type, and PTP switch type configuration are not
available.
Signed-off-by: Manato HIRABAYASHI <[email protected]>
@manato manato requested a review from drwnz June 25, 2024 01:44
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drwnz drwnz merged commit dd9dbb2 into tier4:seyond Jun 26, 2024
3 of 6 checks passed
@manato manato deleted the seyond branch July 2, 2024 09:39
drwnz pushed a commit to tier4/nebula_drs that referenced this pull request Jul 17, 2024
* feat: add initial seyond_hw_interface

This implementation has limited functions; just starting packet
streaming and enqueue them

Signed-off-by: Manato HIRABAYASHI <[email protected]>

* feat: add support to set return mode

Signed-off-by: Manato HIRABAYASHI <[email protected]>

* feat: add support to set PTP profile

This implementation supports configuring IEEE1588v2 or gPTP only. PTP
domain, PTP transport type, and PTP switch type configuration are not
available.
Signed-off-by: Manato HIRABAYASHI <[email protected]>

---------

Signed-off-by: Manato HIRABAYASHI <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants