Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aip_xx1_launch): add input topic remapping #160

Merged
merged 2 commits into from
Jul 28, 2023
Merged

feat(aip_xx1_launch): add input topic remapping #160

merged 2 commits into from
Jul 28, 2023
+4 −1

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Jul 28, 2023 •
edited
Loading

autowarefoundation/sample_sensor_kit_launch#59
と同様にconcatenated nodeのtwistのトピック名を修正します。

According to autowarefoundation/autoware.universe#3877 change, add an argument to set the input topic name for concatenate data node.
Need to use this PR after autowarefoundation/autoware.universe#3877 is merged to autoware.universe

なお、こちらのトピック名間違っていても速度補正されないだけで動きはする、とのこと

1222-takeshi
1222-takeshi approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 450eed2 into tier4/universe Jul 28, 2023
9 of 10 checks passed
@tkimura4 tkimura4 deleted the fix/concatenate_input branch July 28, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1222-takeshi 1222-takeshi 1222-takeshi approved these changes

@Naophis Naophis Awaiting requested review from Naophis

@shmpwk shmpwk Awaiting requested review from shmpwk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkimura4 @1222-takeshi