Move CRS responsibility from GuideAxis to CoordSf #5440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
commented
Sep 27, 2023
R/coord-sf.R
Outdated
| x_range = x_range, | ||
| y_range = y_range, | ||
| graticule = graticule, | ||
| crs = params$crs, | ||
| default_crs = params$default_crs, | ||
| viewscales = viewscales | ||
| !!viewscales |
There was a problem hiding this comment.
This makes CoordSf$setup_panel_guides() redundant and we can rely on parental Coord$setup_panel_guides() instead.
teunbrand
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't fix any issue, but it amends #5293.
I have become mildly frustrated by the lines below in the axis guide:
ggplot2/R/guide-axis.R
Lines 138 to 141 in 69e7430
Which I believe should be the coord's responsibility, not the axis' responsibility. This PR moves that ressponsibility from the axis to the coord.