when there is nothing to stack, exit via var = NULL

tidyverse · Sep 16, 2024 · 961a33f · 961a33f
1 parent 842e6be
commit 961a33f
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/R/position-stack.R b/R/position-stack.R
@@ -153,8 +153,14 @@ PositionStack <- ggproto("PositionStack", Position,
   setup_params = function(self, data) {
     flipped_aes <- has_flipped_aes(data)
     data <- flip_data(data, flipped_aes)
+    var <- self$var %||% stack_var(data)
+    if (!vec_duplicate_any(data$x)) {
+      # We skip stacking when all data have different x positions so that
+      # there is nothing to stack
+      var <- NULL
+    }
     list(
-      var = self$var %||% stack_var(data),
+      var = var,
       fill = self$fill,
       vjust = self$vjust,
       reverse = self$reverse,
@@ -185,10 +191,6 @@ PositionStack <- ggproto("PositionStack", Position,
     if (is.null(params$var)) {
       return(data)
     }
-    if (!vec_duplicate_any(data$x)) {
-      # Every x is unique, nothing to stack here
-      return(flip_data(data, params$flipped_aes))
-    }
 
     negative <- data$ymax < 0
     negative[is.na(negative)] <- FALSE