Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reviewpad onboarding #7

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

feat: reviewpad onboarding #7

wants to merge 33 commits into from

Conversation

reviewpad[bot]
Copy link

@reviewpad reviewpad bot commented Jun 27, 2023

Reviewpad-Thin-Logo-Simple

Welcome to Reviewpad! This is an onboarding pull request to help you configure Reviewpad before it starts speeding up and securing your pull requests.

To activate Reviewpad, merge this Pull Request. To disable Reviewpad, simply close this Pull Request unmerged.

Configuration

Reviewpad is configured by adding a reviewpad.yml to the root of your repository. This file contains a list of workflows that Reviewpad will use to automate actions on your pull requests. Each workflow is triggered based on some defined conditions called rules.

To get you started, we provide a default configuration (attached to this PR) with some best practices.

If you wish to tune this configuration, you can either use our embedded wizard by turning on/off the below checkboxes or simply edit the reviewpad.yml file in this branch and push it. If you decide to manually update the reviewpad.yml configuration file to get access to the full power of Reviewpad, the wizard and so the below checkboxes will vanish.

Please make sure to test your configuration before pushing it. You can run your configuration against a public repository using our Reviewpad Playground.

The workflows part of this default configuration are the following:

  • Summarize open pull request;
  • Assign the pull request to the most relevant reviewers based on code authorship and reviewer availability;
  • Greet contributors on their first pull request;
  • Check conventional commits:
  • Best practices for pull request management:
    • Warn pull requests that do not have an associated GitHub issue;
    • Warn pull requests if their description is empty;
    • Warn pull requests that do not have a linear history (i.e. commits come after one another);
  • Label pull requests based on their size to boost smaller pull requests;
  • Label pull requests with waiting-for-review if there missing approvals;
  • Label pull requests based on the type of changes:
    • Label pull requests with docs if they only modify Markdown or txt files;
    • Label pull requests with infra if they modify Terraform files;
    • Label pull requests with dependencies if they only modify package.json and package.lock files;
  • Fail Reviewpad check on pull requests that modify any LICENSE;

What to Expect

With your current configuration, Reviewpad will perform the following automations in the last 5 open pull requests:

  • chore(deps): update dependency workbox-cli to v6.6.0 - autoclosed #1

    • Assign reviewer based on code authorship and reviewer availability
    • Lint commit messages with conventional commits
    • Lint pull request title with conventional commits
    • Add warning message "Please link an issue to the pull request"
    • Add label "large"
    • Add label "waiting-for-review"
  • chore(deps): update dependency html-minifier-terser to v7.2.0 - autoclosed #2

    • Assign reviewer based on code authorship and reviewer availability
    • Lint commit messages with conventional commits
    • Lint pull request title with conventional commits
    • Add warning message "Please link an issue to the pull request"
    • Add label "large"
    • Add label "waiting-for-review"
  • chore(deps): update dependency zx to v7.2.3 - autoclosed #4

    • Assign reviewer based on code authorship and reviewer availability
    • Lint commit messages with conventional commits
    • Lint pull request title with conventional commits
    • Add warning message "Please link an issue to the pull request"
    • Add label "medium"
    • Add label "waiting-for-review"
  • chore(deps): update actions/deploy-pages action to v2 - autoclosed #5

    • Assign reviewer based on code authorship and reviewer availability
    • Lint commit messages with conventional commits
    • Lint pull request title with conventional commits
    • Add warning message "Please link an issue to the pull request"
    • Add label "small"
    • Add label "waiting-for-review"
  • chore(deps): update dependency workbox-cli to v7 #6

    • Assign reviewer based on code authorship and reviewer availability
    • Lint commit messages with conventional commits
    • Lint pull request title with conventional commits
    • Add warning message "Please link an issue to the pull request"
    • Add label "large"
    • Add label "waiting-for-review"

Need help?

If you have any questions please check out our documentation or get in touch with us.


This PR has been generated by Reviewpad and it was triggered by the installation of the Reviewpad GitHub App.

linonetwo and others added 30 commits June 1, 2023 13:50
解决办法就是写p标签,但问题是中文部分不受影响,就挺离谱,明天看看能不能复现反馈过去。
对比之后发现,英文这边的是通过h2标签来增加标签层级的,导致了后面的内容只有一个p标签,也就是其他像有序列表无序列表的样式丢失了。改成和中文一样的实现方式就没问题了。我测试了其中一个条目,是正常显示。其他条目用的是p标签的方式就不再改了。后续有改动的话再改。
想了想还是修改过来了,这个时候不改,以后可能就忘了,不愿意改了,造成文档格式不统一,那就麻烦了。
dongrentianyu and others added 3 commits June 2, 2023 16:03
起因whitefall说太素了,而且没有欲望浏览下去。我想了想可能是因为背景图片的缘故,背景图片确实有一种墓碑的庄严,肃穆的意味,我想了想就删除了。后面换成notebook米色的主题配色。但还是有一点素,这是因为太微里的主题配色基本上都是纯色的,如果搞渐变色一类的,或者更炫酷的,就得花时间专门去写了。这就只能等其他人来做了。
加了一个插件,但不知道还能不能显示图片出来。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants