Skip to content

Python 3.7 Upgrade

Python 3.7 Upgrade #63

GitHub Actions / Test Results failed May 23, 2024 in 0s

149 fail, 47 skipped, 5 248 pass in 26m 6s

5 444 tests  +5 444   5 248 ✅ +5 248   26m 6s ⏱️ + 26m 6s
    1 suites +    1      47 💤 +   47 
    1 files   +    1     149 ❌ +  149 

Results for commit 306c695. ± Comparison against earlier commit 3a2c647.

Annotations

Check warning on line 195 in src/olympia/activity/tests/test_utils.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_developer_comment (src.olympia.activity.tests.test_utils.TestAddEmailToActivityLog) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_utils.py:198: in test_developer_comment
    note = add_email_to_activity_log(self.parser)
src/olympia/activity/utils.py:156: in add_email_to_activity_log
    note = log_and_notify(log_type, parser.reply, user, version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 202 in src/olympia/activity/tests/test_utils.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_reviewer_comment (src.olympia.activity.tests.test_utils.TestAddEmailToActivityLog) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_utils.py:205: in test_reviewer_comment
    note = add_email_to_activity_log(self.parser)
src/olympia/activity/utils.py:156: in add_email_to_activity_log
    note = log_and_notify(log_type, parser.reply, user, version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 683 in src/olympia/activity/tests/test_utils.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_comment_entity_decode (src.olympia.activity.tests.test_utils.TestLogAndNotify) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_utils.py:690: in test_comment_entity_decode
    log_and_notify(action, comments, self.reviewer, self.version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 390 in src/olympia/activity/tests/test_utils.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_content_reviewer_request_for_information (src.olympia.activity.tests.test_utils.TestLogAndNotify) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_utils.py:395: in test_content_reviewer_request_for_information
    self.test_reviewer_request_for_information()
/usr/local/lib/python2.7/site-packages/mock/mock.py:1305: in patched
    return func(*args, **keywargs)
src/olympia/activity/tests/test_utils.py:302: in test_reviewer_request_for_information
    amo.LOG.REQUEST_INFORMATION, 'blah', self.reviewer, self.version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 396 in src/olympia/activity/tests/test_utils.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_developer_reply (src.olympia.activity.tests.test_utils.TestLogAndNotify) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_utils.py:410: in test_developer_reply
    log_and_notify(action, comments, self.developer, self.version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 582 in src/olympia/activity/tests/test_utils.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_ex_reviewer_doesnt_get_mail (src.olympia.activity.tests.test_utils.TestLogAndNotify) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_utils.py:593: in test_ex_reviewer_doesnt_get_mail
    log_and_notify(action, comments, self.developer, self.version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 669 in src/olympia/activity/tests/test_utils.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_from_name_escape (src.olympia.activity.tests.test_utils.TestLogAndNotify) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_utils.py:678: in test_from_name_escape
    log_and_notify(action, comments, self.reviewer, self.version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 531 in src/olympia/activity/tests/test_utils.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_mail_needinfo_correct_subject (src.olympia.activity.tests.test_utils.TestLogAndNotify) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_utils.py:537: in test_mail_needinfo_correct_subject
    log_and_notify(action, comments, self.developer, self.version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 695 in src/olympia/activity/tests/test_utils.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_notify_about_previous_activity (src.olympia.activity.tests.test_utils.TestLogAndNotify) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_utils.py:700: in test_notify_about_previous_activity
    notify_about_activity_log(self.addon, self.version, activity)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 384 in src/olympia/activity/tests/test_utils.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_post_reviewer_request_for_information (src.olympia.activity.tests.test_utils.TestLogAndNotify) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_utils.py:389: in test_post_reviewer_request_for_information
    self.test_reviewer_request_for_information()
/usr/local/lib/python2.7/site-packages/mock/mock.py:1305: in patched
    return func(*args, **keywargs)
src/olympia/activity/tests/test_utils.py:302: in test_reviewer_request_for_information
    amo.LOG.REQUEST_INFORMATION, 'blah', self.reviewer, self.version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 602 in src/olympia/activity/tests/test_utils.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_review_url_listed (src.olympia.activity.tests.test_utils.TestLogAndNotify) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_utils.py:611: in test_review_url_listed
    log_and_notify(action, comments, self.developer, self.version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 633 in src/olympia/activity/tests/test_utils.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_review_url_unlisted (src.olympia.activity.tests.test_utils.TestLogAndNotify) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_utils.py:646: in test_review_url_unlisted
    log_and_notify(action, comments, self.developer, self.version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 441 in src/olympia/activity/tests/test_utils.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_reviewer_reply (src.olympia.activity.tests.test_utils.TestLogAndNotify) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_utils.py:450: in test_reviewer_reply
    log_and_notify(action, comments, self.reviewer, self.version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 294 in src/olympia/activity/tests/test_utils.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_reviewer_request_for_information (src.olympia.activity.tests.test_utils.TestLogAndNotify) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_utils.py:302: in test_reviewer_request_for_information
    amo.LOG.REQUEST_INFORMATION, 'blah', self.reviewer, self.version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 324 in src/olympia/activity/tests/test_utils.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_reviewer_request_for_information_close_date (src.olympia.activity.tests.test_utils.TestLogAndNotify) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_utils.py:332: in test_reviewer_request_for_information_close_date
    amo.LOG.REQUEST_INFORMATION, 'blah', self.reviewer, self.version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 354 in src/olympia/activity/tests/test_utils.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_reviewer_request_for_information_far_date (src.olympia.activity.tests.test_utils.TestLogAndNotify) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_utils.py:362: in test_reviewer_request_for_information_far_date
    amo.LOG.REQUEST_INFORMATION, 'blah', self.reviewer, self.version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 505 in src/olympia/activity/tests/test_utils.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_staff_cc_group_get_mail (src.olympia.activity.tests.test_utils.TestLogAndNotify) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_utils.py:511: in test_staff_cc_group_get_mail
    log_and_notify(action, comments, self.developer, self.version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 500 in src/olympia/activity/tests/test_utils.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_staff_cc_group_is_empty_no_failure (src.olympia.activity.tests.test_utils.TestLogAndNotify) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_utils.py:504: in test_staff_cc_group_is_empty_no_failure
    self.version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 564 in src/olympia/activity/tests/test_utils.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_task_user_doesnt_get_mail (src.olympia.activity.tests.test_utils.TestLogAndNotify) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_utils.py:573: in test_task_user_doesnt_get_mail
    log_and_notify(action, comments, self.developer, self.version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 345 in src/olympia/activity/tests/test_views.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_cant_reply_to_old_version (src.olympia.activity.tests.test_views.TestReviewNotesViewSetCreate) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_views.py:362: in test_cant_reply_to_old_version
    new_url, {'comments': u'comménty McCómm€nt'})
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:300: in post
    path, data=data, format=format, content_type=content_type, **extra)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:213: in post
    return self.generic('POST', path, data, content_type, **extra)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:238: in generic
    method, path, data, content_type, secure, **extra)
/usr/local/lib/python2.7/site-packages/django/test/client.py:416: in generic
    return self.request(**r)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:289: in request
    return super(APIClient, self).request(**kwargs)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:241: in request
    request = super(APIRequestFactory, self).request(**kwargs)
/usr/local/lib/python2.7/site-packages/django/test/client.py:501: in request
    six.reraise(*exc_info)
/usr/local/lib/python2.7/site-packages/rest_framework/views.py:480: in dispatch
    response = handler(request, *args, **kwargs)
src/olympia/activity/views.py:71: in create
    request.user, version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 370 in src/olympia/activity/tests/test_views.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_developer_can_reply_to_disabled_version (src.olympia.activity.tests.test_views.TestReviewNotesViewSetCreate) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_views.py:373: in test_developer_can_reply_to_disabled_version
    self.test_developer_reply()
src/olympia/activity/tests/test_views.py:270: in test_developer_reply
    response = self._post_reply()
src/olympia/activity/tests/test_views.py:247: in _post_reply
    return self.client.post(self.url, {'comments': u'comménty McCómm€nt'})
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:300: in post
    path, data=data, format=format, content_type=content_type, **extra)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:213: in post
    return self.generic('POST', path, data, content_type, **extra)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:238: in generic
    method, path, data, content_type, secure, **extra)
/usr/local/lib/python2.7/site-packages/django/test/client.py:416: in generic
    return self.request(**r)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:289: in request
    return super(APIClient, self).request(**kwargs)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:241: in request
    request = super(APIRequestFactory, self).request(**kwargs)
/usr/local/lib/python2.7/site-packages/django/test/client.py:501: in request
    six.reraise(*exc_info)
/usr/local/lib/python2.7/site-packages/rest_framework/views.py:480: in dispatch
    response = handler(request, *args, **kwargs)
src/olympia/activity/views.py:71: in create
    request.user, version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 263 in src/olympia/activity/tests/test_views.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_developer_reply (src.olympia.activity.tests.test_views.TestReviewNotesViewSetCreate) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_views.py:270: in test_developer_reply
    response = self._post_reply()
src/olympia/activity/tests/test_views.py:247: in _post_reply
    return self.client.post(self.url, {'comments': u'comménty McCómm€nt'})
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:300: in post
    path, data=data, format=format, content_type=content_type, **extra)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:213: in post
    return self.generic('POST', path, data, content_type, **extra)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:238: in generic
    method, path, data, content_type, secure, **extra)
/usr/local/lib/python2.7/site-packages/django/test/client.py:416: in generic
    return self.request(**r)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:289: in request
    return super(APIClient, self).request(**kwargs)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:241: in request
    request = super(APIRequestFactory, self).request(**kwargs)
/usr/local/lib/python2.7/site-packages/django/test/client.py:501: in request
    six.reraise(*exc_info)
/usr/local/lib/python2.7/site-packages/rest_framework/views.py:480: in dispatch
    response = handler(request, *args, **kwargs)
src/olympia/activity/views.py:71: in create
    request.user, version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 285 in src/olympia/activity/tests/test_views.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_developer_reply_unlisted (src.olympia.activity.tests.test_views.TestReviewNotesViewSetCreate) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_views.py:288: in test_developer_reply_unlisted
    self.test_developer_reply()
src/olympia/activity/tests/test_views.py:270: in test_developer_reply
    response = self._post_reply()
src/olympia/activity/tests/test_views.py:247: in _post_reply
    return self.client.post(self.url, {'comments': u'comménty McCómm€nt'})
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:300: in post
    path, data=data, format=format, content_type=content_type, **extra)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:213: in post
    return self.generic('POST', path, data, content_type, **extra)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:238: in generic
    method, path, data, content_type, secure, **extra)
/usr/local/lib/python2.7/site-packages/django/test/client.py:416: in generic
    return self.request(**r)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:289: in request
    return super(APIClient, self).request(**kwargs)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:241: in request
    request = super(APIRequestFactory, self).request(**kwargs)
/usr/local/lib/python2.7/site-packages/django/test/client.py:501: in request
    six.reraise(*exc_info)
/usr/local/lib/python2.7/site-packages/rest_framework/views.py:480: in dispatch
    response = handler(request, *args, **kwargs)
src/olympia/activity/views.py:71: in create
    request.user, version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 374 in src/olympia/activity/tests/test_views.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_reviewer_can_reply_to_disabled_version_listed (src.olympia.activity.tests.test_views.TestReviewNotesViewSetCreate) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_views.py:377: in test_reviewer_can_reply_to_disabled_version_listed
    self._test_reviewer_reply('Addons:Review')
src/olympia/activity/tests/test_views.py:296: in _test_reviewer_reply
    response = self._post_reply()
src/olympia/activity/tests/test_views.py:247: in _post_reply
    return self.client.post(self.url, {'comments': u'comménty McCómm€nt'})
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:300: in post
    path, data=data, format=format, content_type=content_type, **extra)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:213: in post
    return self.generic('POST', path, data, content_type, **extra)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:238: in generic
    method, path, data, content_type, secure, **extra)
/usr/local/lib/python2.7/site-packages/django/test/client.py:416: in generic
    return self.request(**r)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:289: in request
    return super(APIClient, self).request(**kwargs)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:241: in request
    request = super(APIRequestFactory, self).request(**kwargs)
/usr/local/lib/python2.7/site-packages/django/test/client.py:501: in request
    six.reraise(*exc_info)
/usr/local/lib/python2.7/site-packages/rest_framework/views.py:480: in dispatch
    response = handler(request, *args, **kwargs)
src/olympia/activity/views.py:71: in create
    request.user, version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)

Check warning on line 378 in src/olympia/activity/tests/test_views.py

See this annotation in the file changed.

@github-actions github-actions / Test Results

test_reviewer_can_reply_to_disabled_version_unlisted (src.olympia.activity.tests.test_views.TestReviewNotesViewSetCreate) failed

src/test_report.xml [took 0s]
Raw output
TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)
src/olympia/activity/tests/test_views.py:382: in test_reviewer_can_reply_to_disabled_version_unlisted
    self._test_reviewer_reply('Addons:ReviewUnlisted')
src/olympia/activity/tests/test_views.py:296: in _test_reviewer_reply
    response = self._post_reply()
src/olympia/activity/tests/test_views.py:247: in _post_reply
    return self.client.post(self.url, {'comments': u'comménty McCómm€nt'})
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:300: in post
    path, data=data, format=format, content_type=content_type, **extra)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:213: in post
    return self.generic('POST', path, data, content_type, **extra)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:238: in generic
    method, path, data, content_type, secure, **extra)
/usr/local/lib/python2.7/site-packages/django/test/client.py:416: in generic
    return self.request(**r)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:289: in request
    return super(APIClient, self).request(**kwargs)
/usr/local/lib/python2.7/site-packages/rest_framework/test.py:241: in request
    request = super(APIRequestFactory, self).request(**kwargs)
/usr/local/lib/python2.7/site-packages/django/test/client.py:501: in request
    six.reraise(*exc_info)
/usr/local/lib/python2.7/site-packages/rest_framework/views.py:480: in dispatch
    response = handler(request, *args, **kwargs)
src/olympia/activity/views.py:71: in create
    request.user, version)
src/olympia/activity/utils.py:214: in log_and_notify
    version.addon, version, note, perm_setting=perm_setting)
src/olympia/activity/utils.py:237: in notify_about_activity_log
    comments = HTMLParser.unescape(comments)
E   TypeError: unbound method unescape() must be called with HTMLParser instance as first argument (got unicode instance instead)