Cache unauthenticated GET/HEAD requests for one hour. #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results5 481 tests ±0 5 393 ✅ - 1 28m 56s ⏱️ -21s For more details on these failures, see this check. Results for commit e708441. ± Comparison against base commit 9af0935. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will affect all GET/HEAD requests even api calls. I'm not sure if that's something we majorly care about though.
In private browser on my dev environment, not being logged in I get
cache-control: max-age=3600, otherwise being logged in I don't get a cache-control header. Let me know if you want an explicit max-age=0 header anywhere.