Remove Personas #285
Merged
Remove Personas #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results5 491 tests +10 5 402 ✅ +8 27m 34s ⏱️ +17s For more details on these failures, see this check. Results for commit 11a34af. ± Comparison against base commit 414d9fe. ♻️ This comment has been updated with latest results. |
|
Updated the destroy test to include other addon types. Test still passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #284
There's two commands added here:
./personas.csv. I'm expecting that csv to be around 60-100mb. 😱I've also added a hard parameter (matching some other delete functions) to hard delete an addon. By default they soft delete (and also that sends an email to the addon owner 😱) which basically sets the status to deleted and removes it from normal object listing. We don't need these anymore, so lets just remove it entirely from the db.
After I get the csv of personas I'll create a github repo with some markdown lists pointing to AMO. (Might have to the files down by by alphabetical order.)