Restrict manifest v3 to 128.0 (Fixes #280)

[MelissaAutumn]

Fixes #280

This adds two additional checks to our manifest.json parser.

1. If a manifest.json has manifest_version: 3, require that strict_min_version exists and is greater than or equal to 128.0b1.
2. If a manifest.json has manifest_version: 3 don't allow the applications key.

cc @jobisoft

[github-actions]

Test Results

5 489 tests  +8   5 402 ✅ +10   27m 21s ⏱️ - 1m 49s
    1 suites ±0      25 💤  -  1 
    1 files   ±0      62 ❌  -  1 

For more details on these failures, see this check.

Results for commit 2dfd1e1. ± Comparison against base commit c8e9457.

This pull request removes 1 and adds 9 tests. Note that renamed tests count towards both.

src.olympia.addons.tests.test_commands.TestDeleteAddonsNotCompatibleWithFirefoxes ‑ test_basic

src.olympia.addons.tests.test_commands.TestDeleteAddonsNotCompatibleWithThunderbird ‑ test_basic
src.olympia.files.tests.test_utils_.TestManifestJSONExtractor ‑ test_manifest_version_3_doesnt_allow_applications_key
src.olympia.files.tests.test_utils_.TestManifestJSONExtractor ‑ test_manifest_version_3_requires_128_fail_due_to_lower_version
src.olympia.files.tests.test_utils_.TestManifestJSONExtractor ‑ test_manifest_version_3_requires_128_fails
src.olympia.files.tests.test_utils_.TestManifestJSONExtractor ‑ test_manifest_version_3_requires_128_passes
src.olympia.files.tests.test_utils_.TestManifestJSONExtractorStaticTheme ‑ test_manifest_version_3_doesnt_allow_applications_key
src.olympia.files.tests.test_utils_.TestManifestJSONExtractorStaticTheme ‑ test_manifest_version_3_requires_128_fail_due_to_lower_version
src.olympia.files.tests.test_utils_.TestManifestJSONExtractorStaticTheme ‑ test_manifest_version_3_requires_128_fails
src.olympia.files.tests.test_utils_.TestManifestJSONExtractorStaticTheme ‑ test_manifest_version_3_requires_128_passes

♻️ This comment has been updated with latest results.

[jobisoft]

I added 128.0b1 as an actual usable app version:

[Sancus]

Not sure there is such a thing as "b1" at all? I thought betas had internal version the same as release, intentionally so. A letter is only present on Daily versions.

[jobisoft]

Not sure there is such a thing as "b1" at all? I thought betas had internal version the same as release, intentionally so. A letter is only present on Daily versions.

How do we solve this?

In our past communication, we said (as an example) 128.0 is greater than 128.0a1. And indeed, I cannot install an add-on in 128 Daily with "strict_min_version": "128.0".

I can however install an add-on in 127 Beta with "strict_min_version": "127.0". So it appears the order is

*.0a1 < *.0 <= *.0b1 (probably because it is just like *.0)

Is that correct? Based on my test with "strict_min_version": "127.0", we then should be fine with enforcing a min version of 128.0 for Manifest V3, as that will exclude Daily, but include Beta, which is what I want.

Does that sound sensible?

[MelissaAutumn]

Its a two second change so let me know if it should be 128!

[jobisoft]

Its a two second change so let me know if it should be 128!

Yes, it must be 128.0 as minimum requirement. Thanks!

[MelissaAutumn]

Okay changes are up. Any final reviews before this is good to merge?

[jobisoft]

Okay changes are up. Any final reviews before this is good to merge?

Andrei is set as reviewer, so I did not look. Shall I take a look?

[MelissaAutumn]

Ah it was meant to either of you really 😄, and if you'd like!

cc @Sancus

[Sancus]

Seems OK to me,

[MelissaAutumn]

Will test it on stage, and merge it up after. Thanks!