Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not process entries from poetry.lock until their category is known #299

Merged
merged 11 commits into from
Jun 21, 2024

Conversation

frenzymadness
Copy link
Collaborator

Related Issues and Dependencies

#295

Let's see what this change will break. I expect possible incompatibility with older poetry.

@frenzymadness
Copy link
Collaborator Author

Now is the time to check the failures and see whether the code is wrong or the test is wrong.

@frenzymadness
Copy link
Collaborator Author

There are two kind of breaking changes now:

  • Packages are allowed to be in more than one category - the category is either derived from the content of pyproject.toml (for direct dependencies) or from the package with another package as a dependency (to be in the same category).
  • Because of the previous point, packages might be mentioned more than once in pipfiles (where it make sense) but we do not allow duplicities in requirements files.

@frenzymadness
Copy link
Collaborator Author

It seems that the new test with complex dependencies is not compatible with Python <= 3.7. Fixed.

@frenzymadness
Copy link
Collaborator Author

This is a big change. A review is necessary. Cc: @fridex @yrro

@frenzymadness
Copy link
Collaborator Author

Does anybody have a plan to do a review?

@fridex
Copy link
Collaborator

fridex commented Jun 10, 2024

Does anybody have a plan to do a review?

I had a brief look on changes - it looks like they are well covered by tests. Unfortunately, I don't have time for an in-depth review. Feel free to consider +1 from me. Very nice job and thanks for looking into this! 👍🏻 💯

It would be great if @yrro could verify this patchset on the originally reported issue or provide the related lockfile (if not done already).

@yrro
Copy link
Contributor

yrro commented Jun 10, 2024

I think my pyproject.toml and lockfile made it into the tests for this PR. But I hope I can give it a manual test on my proejct some time this week.

@frenzymadness
Copy link
Collaborator Author

Thank you both. Sam is correct - his configuration is now part of the tests.

@frenzymadness
Copy link
Collaborator Author

Or we can test it out there in the wild with a new release 🤔

@frenzymadness
Copy link
Collaborator Author

All right, let's give it a try.

@frenzymadness frenzymadness merged commit 15674c5 into thoth-station:master Jun 21, 2024
100 checks passed
@frenzymadness frenzymadness deleted the fix_order branch June 21, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants